Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible fix for issue #7930 HotChocolate.Types.Filters Null Reference issue #7931

Closed

Conversation

olu-lebara
Copy link

Changed order of operations during combine

  • If filter condition is complex, expression for IQueryable could have mistakes. For example

  • ($r.ItemSetting).Data == 123 && $r.ItemSetting != null

  • first it checks property value, and only then checks object is not null.

  • In my case (described in original topic) fix changed order and issue is gone

Closes #7930

Original post with details and issue explanation - #7850

@CLAassistant
Copy link

CLAassistant commented Jan 15, 2025

CLA assistant check
All committers have signed the CLA.

@glen-84 glen-84 changed the title Pissible fix for issue #7930 HotChocolate.Types.Filters Null Referene issue Possible fix for issue #7930 HotChocolate.Types.Filters Null Reference issue Jan 15, 2025
@michaelstaib
Copy link
Member

@olu-lebara We are not doing any fixes to 11 ... can you create a pr to main?

@michaelstaib
Copy link
Member

Types.Filters does no longer exist. HotChocolate.Data is the replacement.

@olu-lebara
Copy link
Author

olu-lebara commented Jan 21, 2025

Thanks @michaelstaib, unfortunately issue is not reproduced (at least in my case) for HotChocolate.Data and last version of HotChocolate. Filters (where condition) was redesigned a lot, and has different filter conditions format. That's why we cannot update to latest version due to compatibility with old queries.
Is it possible somehow to use old filtering format (_some, _any) with HotChocolate.Data package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants