Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Infrastructure #4

Merged
merged 11 commits into from
Aug 3, 2018
Merged

Refactor Infrastructure #4

merged 11 commits into from
Aug 3, 2018

Conversation

fazo96
Copy link
Collaborator

@fazo96 fazo96 commented Aug 1, 2018 •
edited
Loading

What's missing:

  • Collector integration tests moved here from chlu-ipfs
  • add a Collector test to verify that it collects DIDs
  • Write API Client integration tests with API Servers and ChluIPFS
  • Integration test the registerToMarketplace() function
  • Integration test DID Service ?

@fazo96 fazo96 self-assigned this Aug 1, 2018
@fazo96 fazo96 requested a review from kulpreet August 1, 2018 10:12
@fazo96 fazo96 changed the title [WIP] Refactor Infrastructure Refactor Infrastructure Aug 2, 2018
@kulpreet
Copy link

kulpreet commented Aug 3, 2018

Whats the story with the tick boxes in the PR comment again? Create cards for those before merging this?

@fazo96
Copy link
Collaborator Author

fazo96 commented Aug 3, 2018

@kulpreet cards created, #6 #5

@kulpreet kulpreet merged commit 96e225a into master Aug 3, 2018
@kulpreet kulpreet deleted the refactor branch August 3, 2018 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulpreet kulpreet Awaiting requested review from kulpreet

Assignees

@fazo96 fazo96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fazo96 @kulpreet