-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for ASID playback over MIDI, interfacing SIDs on hardware (#178) #179
Draft
micheldebree
wants to merge
22
commits into
master
Choose a base branch
from
asid-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When new configuration item is set to a MIDI interface name, ASID will be sent out in parallel with the reSID audio * Tested with MacOS and Windows * Non-tested support for Linux included * Based on compiled-in RtMidi
…te the cycle offset from the first write. The address range the inspection is done for is 0xd400 to and including 0xd406. The same write order can be assumed for the two other channels. Writes to 0xd415 to 0xd418 does not require any ordering or timing to function adequately.
…et when song is loaded
[trivial] Added comments to sections of ASID specific code that should be moved (and possibly encapsulated)
[minor] Added utility for rtmidi functionality that is better maintained in that context [minor] Changed handlng of opening midi out port. Kept the ini files option, but if that is not set there's a dialogue that can be invoked from the intro screen (only for now) [minor] Added Thomas Jansson to the programmers credits, and same for the author of the RtMidi library
…into asid-support
…here is no out port open already
…l zero ADSR and Control reg on each channel by sending a midi package to the device.
About the toggle:
|
- Only toggleable with mouse - Does nothing except keep the setting in AuxilaryDataHardwarePreferences
This reverts commit c231b06.
…pointer to a volatile memory address by using it there.
…d value due to not scoping the instance of T in a union.
* Switch for ASID/RESID output * Removed obsolete comment * Fix parentheses style * Formatter config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Documentation
Playback.ASID.MidiInterface
config option in theuser.ini
Alt-O
(visible in top bar. If it doesn't change, there is no MIDI device found)Example for macOS
In
~/.config/sidfactory2/user.ini
:A way to find out the available values, is to run SF2 from the terminal and check the logging: