-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release CI/CD workflow #46
Conversation
olisovyi-everstake
commented
Jul 8, 2024
•
edited
Loading
edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for the contribution!
Hi @olisovyi-everstake! Thank you one more time for adding the release job, we would be happy to make use of it going forward. Can you please pull latest main branch changes into your fork, so CI triggers can run and we can merge your contribution. Sorry, we originally set CI to only work on branch pushes, but now made it to run on pull requests, so to merge your PR need to update it with the changes to satisfy our required checks. |
@mksh please check |
it's now failing at cargo-deny vulnerability check- i can provide a PR to fix |
@jenpaff failing at cargo-deny - I had it initially |
I just fixed it on a separate PR, should be able to rebase. |
we made it :) thanks @olisovyi-everstake for your contribution |
@jenpaff Always happy to contribute) |