Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release CI/CD workflow #46

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Add release CI/CD workflow #46

merged 3 commits into from
Jul 29, 2024

Conversation

olisovyi-everstake
Copy link
Contributor

@olisovyi-everstake olisovyi-everstake commented Jul 8, 2024

image

Copy link
Contributor

@mksh mksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the contribution!

@mksh mksh mentioned this pull request Jul 16, 2024
@mksh
Copy link
Contributor

mksh commented Jul 19, 2024

Hi @olisovyi-everstake! Thank you one more time for adding the release job, we would be happy to make use of it going forward.

Can you please pull latest main branch changes into your fork, so CI triggers can run and we can merge your contribution.

Sorry, we originally set CI to only work on branch pushes, but now made it to run on pull requests, so to merge your PR need to update it with the changes to satisfy our required checks.

@olisovyi-everstake
Copy link
Contributor Author

@mksh please check

@jenpaff
Copy link
Contributor

jenpaff commented Jul 24, 2024

it's now failing at cargo-deny vulnerability check- i can provide a PR to fix

@olisovyi-everstake
Copy link
Contributor Author

@jenpaff failing at cargo-deny - I had it initially

@jenpaff
Copy link
Contributor

jenpaff commented Jul 27, 2024

@jenpaff failing at cargo-deny - I had it initially

I just fixed it on a separate PR, should be able to rebase.

@jenpaff jenpaff merged commit e5c8eaf into ChorusOne:main Jul 29, 2024
2 checks passed
@jenpaff
Copy link
Contributor

jenpaff commented Jul 29, 2024

we made it :) thanks @olisovyi-everstake for your contribution

@olisovyi-everstake
Copy link
Contributor Author

@jenpaff Always happy to contribute)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants