-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export gossip with macro #73
base: prometheus
Are you sure you want to change the base?
Commits on Jul 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 5e080e1 - Browse repository at this point
Copy the full SHA 5e080e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15ded10 - Browse repository at this point
Copy the full SHA 15ded10View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b20faf - Browse repository at this point
Copy the full SHA 8b20fafView commit details -
Configuration menu - View commit details
-
Copy full SHA for b0f40a1 - Browse repository at this point
Copy the full SHA b0f40a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for a728409 - Browse repository at this point
Copy the full SHA a728409View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5332470 - Browse repository at this point
Copy the full SHA 5332470View commit details -
Configuration menu - View commit details
-
Copy full SHA for 906f67c - Browse repository at this point
Copy the full SHA 906f67cView commit details -
When referring to our node, we use simply `node` as opposed to `cluster`.
Configuration menu - View commit details
-
Copy full SHA for 3a958c3 - Browse repository at this point
Copy the full SHA 3a958c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba68332 - Browse repository at this point
Copy the full SHA ba68332View commit details -
Configuration menu - View commit details
-
Copy full SHA for d734527 - Browse repository at this point
Copy the full SHA d734527View commit details -
Configuration menu - View commit details
-
Copy full SHA for f528d3e - Browse repository at this point
Copy the full SHA f528d3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 253ac1c - Browse repository at this point
Copy the full SHA 253ac1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ecd70c1 - Browse repository at this point
Copy the full SHA ecd70c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d09704 - Browse repository at this point
Copy the full SHA 2d09704View commit details -
Configuration menu - View commit details
-
Copy full SHA for bfc1328 - Browse repository at this point
Copy the full SHA bfc1328View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad78d65 - Browse repository at this point
Copy the full SHA ad78d65View commit details -
Configuration menu - View commit details
-
Copy full SHA for aedcbe4 - Browse repository at this point
Copy the full SHA aedcbe4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ddf4cdf - Browse repository at this point
Copy the full SHA ddf4cdfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 78fe0c8 - Browse repository at this point
Copy the full SHA 78fe0c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a861d9 - Browse repository at this point
Copy the full SHA 2a861d9View commit details -
Instead of propagating `rpc_processor`, use the `block_commitment_cache` structure to get different bank confirmation levels
Configuration menu - View commit details
-
Copy full SHA for 390a8c5 - Browse repository at this point
Copy the full SHA 390a8c5View commit details -
Limit
block_commitment_cache
read lock.As ruuda pointed out, there is a deadlock if we acquire a read lock for both `block_commitment_cache` and `bank_forks`, in ruuda words: - We take the read lock on block_commitment_cache. - Some other thread takes a write lock on bank_forks. - We want to take the read lock on bank_forks, but this blocks because the other thread holds a write lock. - The other thread wants to take a write lock on block_commitment_cache, but that blocks because we hold the read lock. - Deadlock! Instead, we guard the `block_commitment_cache` read lock so we don't hold two read locks concurrently. This might lead, as ruuda also pointed out, to an inconsistency that's known to Solana and dealt already in the code the same way it's dealt in `rpc/src/rpc.rs`.
Configuration menu - View commit details
-
Copy full SHA for 399e9e1 - Browse repository at this point
Copy the full SHA 399e9e1View commit details -
Should be "counter", not "count"
Configuration menu - View commit details
-
Copy full SHA for 2aebf10 - Browse repository at this point
Copy the full SHA 2aebf10View commit details -
Save metrics about the validator's vote account
Also update Cargo.lock.
Configuration menu - View commit details
-
Copy full SHA for b7e4d96 - Browse repository at this point
Copy the full SHA b7e4d96View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d97a4e - Browse repository at this point
Copy the full SHA 9d97a4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f25093e - Browse repository at this point
Copy the full SHA f25093eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e224e52 - Browse repository at this point
Copy the full SHA e224e52View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad69c55 - Browse repository at this point
Copy the full SHA ad69c55View commit details -
Configuration menu - View commit details
-
Copy full SHA for f9727f3 - Browse repository at this point
Copy the full SHA f9727f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11a6f7f - Browse repository at this point
Copy the full SHA 11a6f7fView commit details -
Add parameter to observe vote accounts.
Down the rabbit hole from the arguments, propagating it to the prometheus part, we add a flag so we can track multiple vote accounts.
Configuration menu - View commit details
-
Copy full SHA for 3a1fad8 - Browse repository at this point
Copy the full SHA 3a1fad8View commit details -
Modify how metrics are written to account for when there's nothing to report. Add metrics about votes: last voted and vote balance
Configuration menu - View commit details
-
Copy full SHA for c5421d1 - Browse repository at this point
Copy the full SHA c5421d1View commit details -
Naming changes, add vote credits information
Change variable and function names, and add information about vote credits
Configuration menu - View commit details
-
Copy full SHA for 0888bc4 - Browse repository at this point
Copy the full SHA 0888bc4View commit details -
Slight change on how metrics are recorded
Configuration menu - View commit details
-
Copy full SHA for d7045e7 - Browse repository at this point
Copy the full SHA d7045e7View commit details -
Rename prometheus metrics help
Co-authored-by: Ruud van Asseldonk <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for da01458 - Browse repository at this point
Copy the full SHA da01458View commit details -
Configuration menu - View commit details
-
Copy full SHA for e432aae - Browse repository at this point
Copy the full SHA e432aaeView commit details -
Configuration menu - View commit details
-
Copy full SHA for b711766 - Browse repository at this point
Copy the full SHA b711766View commit details -
Configuration menu - View commit details
-
Copy full SHA for e45bbac - Browse repository at this point
Copy the full SHA e45bbacView commit details -
Configuration menu - View commit details
-
Copy full SHA for ac132cf - Browse repository at this point
Copy the full SHA ac132cfView commit details -
Co-authored-by: Ruud van Asseldonk <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 980fb16 - Browse repository at this point
Copy the full SHA 980fb16View commit details -
Configuration menu - View commit details
-
Copy full SHA for d46b45a - Browse repository at this point
Copy the full SHA d46b45aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0af8d74 - Browse repository at this point
Copy the full SHA 0af8d74View commit details -
Co-authored-by: Ruud van Asseldonk <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for eb9f025 - Browse repository at this point
Copy the full SHA eb9f025View commit details -
Expose epoch schedule metrics in Prometheus
With the epoch start slots and the number of slots in the epoch (and the current slot, which we already had), we can infer/estimate: * Epoch progress percentage * Slots left until the next epoch * Time left until the next epoch (from slot height increase) These are useful metrics to have about the network.
Configuration menu - View commit details
-
Copy full SHA for db9b7f7 - Browse repository at this point
Copy the full SHA db9b7f7View commit details
Commits on Aug 6, 2022
-
Export gossip metrics with a macro
Derive a macro for `GossipStats`, a less invasive and more concise way of writing all metrics from it. Currently, the macro only accepts `Counter` type and will fail if used otherwise, but we can probably expand it in the future to work with more data types.
Configuration menu - View commit details
-
Copy full SHA for dccf07d - Browse repository at this point
Copy the full SHA dccf07dView commit details -
This function clears the gossip stats.
Configuration menu - View commit details
-
Copy full SHA for 3109cbf - Browse repository at this point
Copy the full SHA 3109cbfView commit details -
Since we commented the previous line, doesn't make sense to update this variable.
Configuration menu - View commit details
-
Copy full SHA for 8f54039 - Browse repository at this point
Copy the full SHA 8f54039View commit details