isInputModulationPort and isOutputModulationPort Removed and Usages R…

…eplaced With getPortType I/O Methods
Chowdhury-DSP · Jun 28, 2023 · 0a5b871 · 0a5b871
1 parent 9d3d88e
commit 0a5b871
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 18 deletions.
diff --git a/src/headless/tests/BadModulationTest.cpp b/src/headless/tests/BadModulationTest.cpp
@@ -16,7 +16,7 @@ class BadModulationTest : public UnitTest
 
             bool hasModulationInputs = false;
             for (int i = 0; i < proc->getNumInputs(); ++i)
-                hasModulationInputs |= proc->isInputModulationPort (i);
+                hasModulationInputs |= proc->getOutputPortType(i) == PortType::modulation;
 
             if (! hasModulationInputs)
                 processorsWithNoModulation.add (proc->getName());

diff --git a/src/processors/BaseProcessor.cpp b/src/processors/BaseProcessor.cpp
@@ -336,12 +336,12 @@ void BaseProcessor::setEditor (ProcessorEditor* procEditor)
     editor = procEditor;
 }
 
-PortType BaseProcessor::getInputPortType (int portIndex)
+PortType BaseProcessor::getInputPortType (int portIndex) const
 {
     return inputPortTypes[portIndex];
 }
 
-PortType BaseProcessor::getOutputPortType (int portIndex)
+PortType BaseProcessor::getOutputPortType (int portIndex) const
 {
     return outputPortTypes[portIndex];
 }
@@ -366,16 +366,6 @@ juce::Point<int> BaseProcessor::getPosition (Rectangle<int> parentBounds)
     return (editorPosition * juce::Point { (float) parentBounds.getWidth(), (float) parentBounds.getHeight() }).toInt();
 }
 
-bool BaseProcessor::isInputModulationPort (int portIndex)
-{
-    return inputPortTypes[portIndex] == PortType::modulation;
-}
-
-bool BaseProcessor::isOutputModulationPort (int portIndex)
-{
-    return outputPortTypes[portIndex] == PortType::modulation;
-}
-
 bool BaseProcessor::isOutputModulationPortConnected()
 {
     if (getProcessorType() != Modulation)
@@ -385,7 +375,7 @@ bool BaseProcessor::isOutputModulationPortConnected()
     {
         for (auto info : connections)
         {
-            if (isOutputModulationPort (info.startPort))
+            if (getOutputPortType(info.startPort) == PortType::modulation)
                 return true;
         }
     }

diff --git a/src/processors/BaseProcessor.h b/src/processors/BaseProcessor.h
@@ -176,17 +176,15 @@ class BaseProcessor : private JuceProcWrapper
 
     int getNumInputs() const noexcept { return numInputs; }
     int getNumOutputs() const noexcept { return numOutputs; }
-    PortType getInputPortType (int portIndex);
-    PortType getOutputPortType (int portIndex);
+    PortType getInputPortType (int portIndex) const;
+    PortType getOutputPortType (int portIndex) const;
 
     void setPosition (juce::Point<int> pos, Rectangle<int> parentBounds);
     void setPosition (const BaseProcessor& other) { editorPosition = other.editorPosition; }
     juce::Point<int> getPosition (Rectangle<int> parentBounds);
 
     const auto& getParameters() const { return AudioProcessor::getParameters(); }
 
-    bool isInputModulationPort (int portIndex);
-    bool isOutputModulationPort (int portIndex);
     bool isOutputModulationPortConnected();
 
     const std::vector<String>* getParametersToDisableWhenInputIsConnected (int portIndex) const noexcept;