Fix crash when loading plugin state in iOS GarageBand (#251)

* Fix crash when loading plugin state in iOS GarageBand

* Apply clang-format

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

.github/workflows/auto-format.yml

@@ -20,11 +20,9 @@ jobs:
     steps:
     - name: Install Linux Deps
       run: |
-        wget https://apt.llvm.org/llvm.sh
-        chmod +x llvm.sh
-        sudo ./llvm.sh 12
-        sudo apt-get install clang-format-12
-        clang-format-12 --version
+        sudo apt update
+        sudo apt -y install clang-format-14
+        clang-format-14 --version
 
     - name: Checkout code
       uses: actions/checkout@v2
@@ -34,7 +32,7 @@ jobs:
 
     - name: Run clang-format
       shell: bash
-      run: find src/ -iname *.h -o -iname *.cpp | xargs clang-format-12 -style=file -verbose -i
+      run: find src/ -iname *.h -o -iname *.cpp | xargs clang-format-14 -style=file -verbose -i
 
     - name: Commit & Push changes
       uses: actions-js/push@master

src/BYOD.cpp

@@ -16,7 +16,7 @@ BYOD::BYOD() : chowdsp::PluginBase<BYOD> (&undoManager),
     Logger::writeToLog (chowdsp::PluginDiagnosticInfo::getDiagnosticsString (*this));
 
     pluginSettings->initialise (settingsFilePath);
-    procs = std::make_unique<ProcessorChain> (procStore, vts, presetManager, [&] (int l)
+    procs = std::make_unique<ProcessorChain> (procStore, vts, presetManager, paramForwarder, [&] (int l)
                                               { updateSampleLatency (l); });
     paramForwarder = std::make_unique<ParamForwardManager> (vts, *procs);
     presetManager = std::make_unique<PresetManager> (procs.get(), vts);

src/gui/utils/HostContextProvider.cpp

@@ -24,7 +24,8 @@ ReturnType HostContextProvider::doForParameterOrForwardedParameter (const Ranged
 std::unique_ptr<HostProvidedContextMenu> HostContextProvider::getContextMenuForParameter (const RangedAudioParameter& param) const
 {
     return doForParameterOrForwardedParameter (param,
-                                               [this] (auto& p) -> std::unique_ptr<HostProvidedContextMenu> {
+                                               [this] (auto& p) -> std::unique_ptr<HostProvidedContextMenu>
+                                               {
                                                    return chowdsp::HostContextProvider::getContextMenuForParameter (p);
                                                });
 }

src/headless/tests/PresetsTest.cpp

@@ -38,8 +38,7 @@ class PresetsTest : public UnitTest
                                          plugin.processBlock (buffer, midi);
                                          bufferCount++;
                                      }
-                                     waiter.signal();
-                                 });
+                                     waiter.signal(); });
 
         int numPrograms = plugin.getNumPrograms();
         for (int i = 0; i < numPrograms; ++i)

src/processors/chain/ProcessorChain.cpp

@@ -21,12 +21,15 @@ namespace
 ProcessorChain::ProcessorChain (ProcessorStore& store,
                                 AudioProcessorValueTreeState& vts,
                                 std::unique_ptr<chowdsp::PresetManager>& presetMgr,
-                                std::function<void (int)>&& latencyChangedCallback) : procStore (store),
-                                                                                      um (vts.undoManager),
-                                                                                      inputProcessor (um),
-                                                                                      outputProcessor (um),
-                                                                                      ioProcessor (vts, std::move (latencyChangedCallback)),
-                                                                                      presetManager (presetMgr)
+                                std::unique_ptr<ParamForwardManager>& paramForwarder,
+                                std::function<void (int)>&& latencyChangedCallback)
+    : procStore (store),
+      um (vts.undoManager),
+      inputProcessor (um),
+      outputProcessor (um),
+      ioProcessor (vts, std::move (latencyChangedCallback)),
+      presetManager (presetMgr),
+      paramForwardManager (paramForwarder)
 {
     actionHelper = std::make_unique<ProcessorChainActionHelper> (*this);
     stateHelper = std::make_unique<ProcessorChainStateHelper> (*this, mainThreadAction);
@@ -214,7 +217,6 @@ void ProcessorChain::parameterChanged (const juce::String& /*parameterID*/, floa
                                jassert (presetManager != nullptr);
 
                                if (! presetManager->getIsDirty())
-                                   presetManager->setIsDirty (true);
-                           },
+                                   presetManager->setIsDirty (true); },
                            true);
 }

src/processors/chain/ProcessorChain.h

@@ -9,12 +9,14 @@
 class ProcessorChainActionHelper;
 class ProcessorChainPortMagnitudesHelper;
 class ProcessorChainStateHelper;
+class ParamForwardManager;
 class ProcessorChain : private AudioProcessorValueTreeState::Listener
 {
 public:
     ProcessorChain (ProcessorStore& store,
                     AudioProcessorValueTreeState& vts,
                     std::unique_ptr<chowdsp::PresetManager>& presetMgr,
+                    std::unique_ptr<ParamForwardManager>& paramForwardManager,
                     std::function<void (int)>&& latencyChangedCallback);
     ~ProcessorChain() override;
 
@@ -73,6 +75,7 @@ class ProcessorChain : private AudioProcessorValueTreeState::Listener
     std::unique_ptr<ProcessorChainPortMagnitudesHelper> portMagsHelper;
 
     chowdsp::DeferredAction mainThreadAction;
+    std::unique_ptr<ParamForwardManager>& paramForwardManager;
 
     JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR (ProcessorChain)
 };

src/processors/chain/ProcessorChainStateHelper.cpp

@@ -1,5 +1,6 @@
 #include "ProcessorChainStateHelper.h"
 #include "ProcessorChainActions.h"
+#include "state/ParamForwardManager.h"
 #include "state/presets/PresetManager.h"
 
 namespace
@@ -30,9 +31,10 @@ String getProcessorName (const String& tag)
 }
 } // namespace
 
-ProcessorChainStateHelper::ProcessorChainStateHelper (ProcessorChain& thisChain, chowdsp::DeferredAction& deferredAction) : chain (thisChain),
-                                                                                                                            um (chain.um),
-                                                                                                                            mainThreadStateLoader (deferredAction)
+ProcessorChainStateHelper::ProcessorChainStateHelper (ProcessorChain& thisChain, chowdsp::DeferredAction& deferredAction)
+    : chain (thisChain),
+      um (chain.um),
+      mainThreadStateLoader (deferredAction)
 {
 }
 
@@ -102,6 +104,8 @@ void ProcessorChainStateHelper::loadProcChainInternal (const XmlElement* xml,
                                                        bool loadingPreset,
                                                        Component* associatedComp)
 {
+    ParamForwardManager::ScopedForceDeferHostNotifications scopedDeferNotifs { *chain.paramForwardManager };
+
     if (! loadingPreset)
         um->beginNewTransaction();
 

src/processors/drive/junior_b/JuniorB.cpp

@@ -69,7 +69,7 @@ void JuniorB::processAudio (AudioBuffer<float>& buffer)
     const auto numSamples = buffer.getNumSamples();
 
     dryBuffer.setCurrentSize (numChannels, numSamples);
-    chowdsp::BufferMath::copyBufferData (chowdsp::BufferView { buffer }, dryBuffer);
+    chowdsp::BufferMath::copyBufferData (buffer, dryBuffer);
 
     const auto drivePercent = driveParamPct->getCurrentValue();
     const auto blendPercent = blendParamPct->getCurrentValue();

src/processors/modulation/phaser/Phaser4.cpp

@@ -33,8 +33,7 @@ Phaser4::Phaser4 (UndoManager* um) : BaseProcessor ("Phaser4",
     lfoShaper.initialise ([] (float x)
                           {
                               static constexpr auto skewFactor = gcem::pow (2.0f, -0.5f);
-                              return 2.0f * std::pow ((x + 1.0f) * 0.5f, skewFactor) - 1.0f;
-                          },
+                              return 2.0f * std::pow ((x + 1.0f) * 0.5f, skewFactor) - 1.0f; },
                           -1.0f,
                           1.0f,
                           2048);

src/processors/modulation/phaser/Phaser8.cpp

@@ -35,8 +35,7 @@ Phaser8::Phaser8 (UndoManager* um) : BaseProcessor ("Phaser8",
     lfoShaper.initialise ([] (float x)
                           {
                               static constexpr auto skewFactor = gcem::pow (2.0f, -0.25f);
-                              return 2.0f * std::pow ((x + 1.0f) * 0.5f, skewFactor) - 1.0f;
-                          },
+                              return 2.0f * std::pow ((x + 1.0f) * 0.5f, skewFactor) - 1.0f; },
                           -1.0f,
                           1.0f,
                           2048);