Fixing MSVC warnings

Chowdhury-DSP · Jul 6, 2023 · c55d136 · c55d136
1 parent ce4b37b
commit c55d136
Show file tree

Hide file tree

Showing 6 changed files with 65 additions and 48 deletions.
diff --git a/src/processors/drive/fuzz_machine/FuzzFaceNDK.cpp b/src/processors/drive/fuzz_machine/FuzzFaceNDK.cpp
@@ -2,6 +2,11 @@
  * This file was generated on 2023-07-04 19:36:50.043506
  * using the command: `/Users/jatin/ChowDSP/Research/NDK-Framework/generate_ndk_cpp.py fuzz_face_ndk_config.json`
  */
+
+#include <pch.h>
+
+JUCE_BEGIN_IGNORE_WARNINGS_MSVC (4459)
+
 #include "FuzzFaceNDK.h"
 
 namespace
@@ -212,3 +217,5 @@ void FuzzFaceNDK::process (std::span<float> channel_data, size_t ch) noexcept
         x_n[ch] = A_mat * x_n[ch] + B_mat_var * u_n_var + B_u_fix + C_mat * i_n;
     }
 }
+
+JUCE_END_IGNORE_WARNINGS_MSVC
diff --git a/src/processors/modulation/phaser/Phaser8.cpp b/src/processors/modulation/phaser/Phaser8.cpp
@@ -76,18 +76,20 @@ ParamLayout Phaser8::createParameterLayout()
 
 String Phaser8::getTooltipForPort (int portIndex, bool isInput)
 {
-    if (isInput)
-        return BaseProcessor::getTooltipForPort (portIndex, isInput);
-
-    switch ((OutputPort) portIndex)
+    if (! isInput)
     {
-        case OutputPort::AudioOutput:
-            return "Stage 8 Output";
-        case OutputPort::Stage1Output:
-            return "Stage 1 Output";
-        case OutputPort::ModulationOutput:
-            return "Modulation Output";
+        switch ((OutputPort) portIndex)
+        {
+            case OutputPort::AudioOutput:
+                return "Stage 8 Output";
+            case OutputPort::Stage1Output:
+                return "Stage 1 Output";
+            case OutputPort::ModulationOutput:
+                return "Modulation Output";
+        }
     }
+
+    return BaseProcessor::getTooltipForPort (portIndex, isInput);
 }
 
 void Phaser8::prepare (double sampleRate, int samplesPerBlock)

diff --git a/src/processors/utility/FreqBandSplitter.cpp b/src/processors/utility/FreqBandSplitter.cpp
@@ -61,16 +61,18 @@ void FreqBandSplitter::processAudioBypassed (AudioBuffer<float>& buffer)
 
 String FreqBandSplitter::getTooltipForPort (int portIndex, bool isInput)
 {
-    if (isInput)
-        return BaseProcessor::getTooltipForPort (portIndex, isInput);
-
-    switch ((OutputPort) portIndex)
+    if (! isInput)
     {
-        case OutputPort::HighBand:
-            return "High Band Output";
-        case OutputPort::MidBand:
-            return "Mid Output";
-        case OutputPort::LowBand:
-            return "Low Band Output";
+        switch ((OutputPort) portIndex)
+        {
+            case OutputPort::HighBand:
+                return "High Band Output";
+            case OutputPort::MidBand:
+                return "Mid Output";
+            case OutputPort::LowBand:
+                return "Low Band Output";
+        }
     }
+
+    return BaseProcessor::getTooltipForPort (portIndex, isInput);
 }
diff --git a/src/processors/utility/Mixer.cpp b/src/processors/utility/Mixer.cpp
@@ -120,18 +120,20 @@ void Mixer::processAudioBypassed (AudioBuffer<float>& buffer)
 
 String Mixer::getTooltipForPort (int portIndex, bool isInput)
 {
-    if (! isInput)
-        return BaseProcessor::getTooltipForPort (portIndex, isInput);
-
-    switch ((InputPort) portIndex)
+    if (isInput)
     {
-        case InputPort::Channel1:
-            return "Channel 1 Input";
-        case InputPort::Channel2:
-            return "Channel 2 Input";
-        case InputPort::Channel3:
-            return "Channel 3 Input";
-        case InputPort::Channel4:
-            return "Channel 4 Input";
+        switch ((InputPort) portIndex)
+        {
+            case InputPort::Channel1:
+                return "Channel 1 Input";
+            case InputPort::Channel2:
+                return "Channel 2 Input";
+            case InputPort::Channel3:
+                return "Channel 3 Input";
+            case InputPort::Channel4:
+                return "Channel 4 Input";
+        }
     }
+
+    return BaseProcessor::getTooltipForPort (portIndex, isInput);
 }
diff --git a/src/processors/utility/StereoMerger.cpp b/src/processors/utility/StereoMerger.cpp
@@ -128,14 +128,16 @@ void StereoMerger::processAudioBypassed (AudioBuffer<float>& buffer)
 
 String StereoMerger::getTooltipForPort (int portIndex, bool isInput)
 {
-    if (! isInput)
-        return BaseProcessor::getTooltipForPort (portIndex, isInput);
-
-    switch ((InputPort) portIndex)
+    if (isInput)
     {
-        case InputPort::LeftChannel:
-            return "Left/Mid Input";
-        case InputPort::RightChannel:
-            return "Right/Side Input";
+        switch ((InputPort) portIndex)
+        {
+            case InputPort::LeftChannel:
+                return "Left/Mid Input";
+            case InputPort::RightChannel:
+                return "Right/Side Input";
+        }
     }
+
+    return BaseProcessor::getTooltipForPort (portIndex, isInput);
 }
diff --git a/src/processors/utility/StereoSplitter.cpp b/src/processors/utility/StereoSplitter.cpp
@@ -110,14 +110,16 @@ void StereoSplitter::processAudioBypassed (AudioBuffer<float>& buffer)
 
 String StereoSplitter::getTooltipForPort (int portIndex, bool isInput)
 {
-    if (isInput)
-        return BaseProcessor::getTooltipForPort (portIndex, isInput);
-
-    switch ((OutputPort) portIndex)
+    if (! isInput)
     {
-        case OutputPort::LeftChannel:
-            return "Left/Mid Output";
-        case OutputPort::RightChannel:
-            return "Right/Side Output";
+        switch ((OutputPort) portIndex)
+        {
+            case OutputPort::LeftChannel:
+                return "Left/Mid Output";
+            case OutputPort::RightChannel:
+                return "Right/Side Output";
+        }
     }
+
+    return BaseProcessor::getTooltipForPort (portIndex, isInput);
 }