Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Level Detective Processor - Audio Processing & Visualiser #322

Merged
merged 18 commits into from
Jul 25, 2023
Merged

Level Detective Processor - Audio Processing & Visualiser #322

merged 18 commits into from
Jul 25, 2023

Conversation

RachelMaryamLocke
Copy link
Contributor

@RachelMaryamLocke RachelMaryamLocke commented Jul 18, 2023 •
edited
Loading

Screenshot 2023-07-25 at 00 51 08

jatinchowdhury18
jatinchowdhury18 reviewed Jul 19, 2023
View reviewed changes
src/processors/other/LevelDetective.h Outdated
@@ -0,0 +1,39 @@
#pragma once

#include "../../modules/chowdsp_utils/modules/gui/chowdsp_visualizers/CompressorPlots/chowdsp_LevelDetectorVisualizer.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should need this include? <chowdsp_visualizers/chowdsp_visualizers.h> should be included in JuceHeader.h, and which should have this header included internally.

@jatinchowdhury18
Copy link
Contributor

Looking good overall! I was thinking it might make sense to override processAudioBypassed(). In its current form, I think the bypass behaviour would just pass through the audio without going through the level detector. I think more likely the behaviour we would want would be a "silent" output if the processor bypassed. Would you agree?

@RachelMaryamLocke
Copy link
Contributor Author

Yes, I agree, it wouldn't make sense for the level output to send out mono audio information when the processor is bypassed, so in the case it is bypassed I have cleared the levelOutBuffer.

@RachelMaryamLocke
Copy link
Contributor Author

Let me know if I'm ok to merge this :)

RachelMaryamLocke and others added 5 commits July 24, 2023 18:25
@RachelMaryamLocke
Update chowdsp_utils submodule reference to the latest commit
6fedda0
@jatinchowdhury18 @github-actions
Adding Krusher module (#323)
53b746b 
* Starting adding Krusher module with Jai DSP

* Cleaning up Jai build process

* More build system improvements

* Working Jai compiler on MacOS and fallback for ARM CPUs

* Add bit reduction

* Add fallback implementation

* Build Krusher regardless of Jai availability

* Trying to get Krusher working with GitHub Actions

* Apply clang-format

* Setting clone path

* Fixing clone path

* One more time

* And again...

* No Jai on Linux (for now)

* Trying to appease Linux

* Trying to fix macros

* Apply clang-format

* Fixing memset bug

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@RachelMaryamLocke
audio input visualiser active when level detective is bypassed
1321b5f
@RachelMaryamLocke
Merge 1321b5f into 53b746b
ef6578d
@github-actions
Apply clang-format
12072ed
@jatinchowdhury18 jatinchowdhury18 merged commit 2f10166 into main Jul 25, 2023
@jatinchowdhury18 jatinchowdhury18 deleted the level_detective_processor branch July 25, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jatinchowdhury18 jatinchowdhury18 jatinchowdhury18 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RachelMaryamLocke @jatinchowdhury18