#76 Adds support for mute args #77
Conversation
There was a problem hiding this comment.
Generally LGTM! 🎉
@drewbrokke - Do you mind testing this action in a repo that I am able to view the action run output (and, sharing the link as part of this PR)? You should be able to test this via updating the action in a workflow to point to your fork at the respective commit hash and then kick off CI.
For now, the input expects a comma-separated list of items, same as the CLI tool. I noticed that some of the options accept newlines or files as inputs, do you want to copy that pattern here instead?
I think what you have now (if I'm understanding the usage/intent correctly) is fine. The action can grow later, if needed, in these ways.
I didn't think there would be too much gained by following that pattern in this case since it's a small set of possible values. Thoughts?
I agree - the newlines / 'files-as-inputs' came from past feature requests, I believe; I feel the same can happen here down the road, if needed.
|
@ChrisCarini I just force-pushed a couple of the suggested changes. Let me know if you'd like to see anything else adjusted. I will also post a link to a usage as soon as I have one. Thanks! |
LGTM! Thank you for incorporating the suggestions/changes! I'll try to give this a spin later this evening. Beyond that and pending your testing of the change, it looks ready to merge! |
Hi @ChrisCarini, this is my first attempt at it.
For now, the input expects a comma-separated list of items, same as the CLI tool. I noticed that some of the options accept newlines or files as inputs, do you want to copy that pattern here instead? I didn't think there would be too much gained by following that pattern in this case since it's a small set of possible values. Thoughts?
ref: #76