Dockerize #1
Dockerize #1
Conversation
|
I've heard great things about Docker, but I just tried to get it to work on Windows and it does not seem to be for the faint of heart on this platform. (It changes system settings that break VirtualBox that require being manually undone via command line... "docker run -v $(pwd)/:/var/app/ vdo/foto2vam:1.0.0" is likely "docker run -v%cwd%/:/var/app/ vdo/foto2vam:1.0.0" on Windows, but then this runs into errors from Docker about mounting drives... I never actually ended up getting this to work on Windows...) I'm fine merging the Dockerfile, especially for people on platforms that Docker works well on. However, I don't think this is the solution for the people running Windows that are unable to get the code to work otherwise. With my (limited) experience of Docker on Windows, I'd say if they were unable to get the python dependencies to work without docker, they won't be able to get docker to work, and it will make difficult-to-undo changes to their system. Maybe if you removed the link to the Windows version, and maybe just say "This may work in Windows if you can run Docker, but is untested?" or something to that affect? Then people who know how to work Docker can use this change, but we don't have to worry about people messing up their computers trying to get Docker running. I just don't want to make it too easy for people to mess up their computers :) |
No description provided.