Roll protocol to r1319565

ChromeDevTools · Jun 26, 2024 · 98a6075 · 98a6075
1 parent 549a18a
commit 98a6075
Show file tree

Hide file tree

Showing 8 changed files with 209 additions and 40 deletions.
diff --git a/changelog.md b/changelog.md
@@ -1,7 +1,72 @@
 
 
+## Roll protocol to r1319565 — _2024-06-26T04:28:01.000Z_
+######  Diff: [`549a18a...7178d42`](https://github.com/ChromeDevTools/devtools-protocol/compare/549a18a...7178d42)
+
+```diff
+@@ browser_protocol.pdl:12426 @@ experimental domain PWA
+       # manifestId.
+       optional string installUrlOrBundleUrl
+
+-  # Uninstals the given manifest_id and closes any opened app windows.
++  # Uninstalls the given manifest_id and closes any opened app windows.
+   command uninstall
+     parameters
+       string manifestId
+@@ -12448,7 +12448,7 @@ experimental domain PWA
+   # used to attach to via Target.attachToTarget or similar APIs.
+   # If some files in the parameters cannot be handled by the web app, they will
+   # be ignored. If none of the files can be handled, this API returns an error.
+-  # If no files provided as the parameter, this API also returns an error.
++  # If no files are provided as the parameter, this API also returns an error.
+   #
+   # According to the definition of the file handlers in the manifest file, one
+   # Target.TargetID may represent a page handling one or more files. The order
+@@ -12465,7 +12465,39 @@ experimental domain PWA
+
+   # Opens the current page in its web app identified by the manifest id, needs
+   # to be called on a page target. This function returns immediately without
+-  # waiting for the app finishing loading.
++  # waiting for the app to finish loading.
+   command openCurrentPageInApp
+     parameters
+       string manifestId
++
++  # If user prefers opening the app in browser or an app window.
++  type DisplayMode extends string
++    enum
++      standalone
++      browser
++
++  # Changes user settings of the web app identified by its manifestId. If the
++  # app was not installed, this command returns an error. Unset parameters will
++  # be ignored; unrecognized values will cause an error.
++  #
++  # Unlike the ones defined in the manifest files of the web apps, these
++  # settings are provided by the browser and controlled by the users, they
++  # impact the way the browser handling the web apps.
++  #
++  # See the comment of each parameter.
++  command changeAppUserSettings
++    parameters
++      string manifestId
++      # If user allows the links clicked on by the user in the app's scope, or
++      # extended scope if the manifest has scope extensions and the flags
++      # `DesktopPWAsLinkCapturingWithScopeExtensions` and
++      # `WebAppEnableScopeExtensions` are enabled.
++      #
++      # Note, the API does not support resetting the linkCapturing to the
++      # initial value, uninstalling and installing the web app again will reset
++      # it.
++      #
++      # TODO(crbug.com/339453269): Setting this value on ChromeOS is not
++      # supported yet.
++      optional boolean linkCapturing
++      optional DisplayMode displayMode
+```
+
 ## Roll protocol to r1317765 — _2024-06-21T04:27:31.000Z_
-######  Diff: [`6859c96...be6c222`](https://github.com/ChromeDevTools/devtools-protocol/compare/6859c96...be6c222)
+######  Diff: [`6859c96...549a18a`](https://github.com/ChromeDevTools/devtools-protocol/compare/6859c96...549a18a)
 
 ```diff
 @@ browser_protocol.pdl:892 @@ experimental domain Audits
@@ -12105,27 +12170,4 @@ index 09c420e..bd277eb 100644
    # Modifies the rule selector.
    command setRuleSelector
      parameters
-```
-
-## Roll protocol to r970581 — _2022-02-14T12:15:16.000Z_
-######  Diff: [`9f8c559...1b1e643`](https://github.com/ChromeDevTools/devtools-protocol/compare/9f8c559...1b1e643)
-
-```diff
-@@ browser_protocol.pdl:1792 @@ experimental domain CSS
-       # The resulting CSS container query rule after modification.
-       CSSContainerQuery containerQuery
-
-+  # Modifies the expression of a supports at-rule.
-+  experimental command setSupportsText
-+    parameters
-+      StyleSheetId styleSheetId
-+      SourceRange range
-+      string text
-+    returns
-+      # The resulting CSS Supports rule after modification.
-+      CSSSupports supports
-+
-   # Modifies the rule selector.
-   command setRuleSelector
-     parameters
 ```
diff --git a/json/browser_protocol.json b/json/browser_protocol.json
@@ -26244,6 +26244,15 @@
                             "type": "string"
                         }
                     ]
+                },
+                {
+                    "id": "DisplayMode",
+                    "description": "If user prefers opening the app in browser or an app window.",
+                    "type": "string",
+                    "enum": [
+                        "standalone",
+                        "browser"
+                    ]
                 }
             ],
             "commands": [
@@ -26289,7 +26298,7 @@
                 },
                 {
                     "name": "uninstall",
-                    "description": "Uninstals the given manifest_id and closes any opened app windows.",
+                    "description": "Uninstalls the given manifest_id and closes any opened app windows.",
                     "parameters": [
                         {
                             "name": "manifestId",
@@ -26321,7 +26330,7 @@
                 },
                 {
                     "name": "launchFilesInApp",
-                    "description": "Opens one or more local files from an installed web app identified by its\nmanifestId. The web app needs to have file handlers registered to process\nthe files. The API returns one or more page Target.TargetIDs which can be\nused to attach to via Target.attachToTarget or similar APIs.\nIf some files in the parameters cannot be handled by the web app, they will\nbe ignored. If none of the files can be handled, this API returns an error.\nIf no files provided as the parameter, this API also returns an error.\n\nAccording to the definition of the file handlers in the manifest file, one\nTarget.TargetID may represent a page handling one or more files. The order\nof the returned Target.TargetIDs is not guaranteed.\n\nTODO(crbug.com/339454034): Check the existences of the input files.",
+                    "description": "Opens one or more local files from an installed web app identified by its\nmanifestId. The web app needs to have file handlers registered to process\nthe files. The API returns one or more page Target.TargetIDs which can be\nused to attach to via Target.attachToTarget or similar APIs.\nIf some files in the parameters cannot be handled by the web app, they will\nbe ignored. If none of the files can be handled, this API returns an error.\nIf no files are provided as the parameter, this API also returns an error.\n\nAccording to the definition of the file handlers in the manifest file, one\nTarget.TargetID may represent a page handling one or more files. The order\nof the returned Target.TargetIDs is not guaranteed.\n\nTODO(crbug.com/339454034): Check the existences of the input files.",
                     "parameters": [
                         {
                             "name": "manifestId",
@@ -26348,11 +26357,32 @@
                 },
                 {
                     "name": "openCurrentPageInApp",
-                    "description": "Opens the current page in its web app identified by the manifest id, needs\nto be called on a page target. This function returns immediately without\nwaiting for the app finishing loading.",
+                    "description": "Opens the current page in its web app identified by the manifest id, needs\nto be called on a page target. This function returns immediately without\nwaiting for the app to finish loading.",
+                    "parameters": [
+                        {
+                            "name": "manifestId",
+                            "type": "string"
+                        }
+                    ]
+                },
+                {
+                    "name": "changeAppUserSettings",
+                    "description": "Changes user settings of the web app identified by its manifestId. If the\napp was not installed, this command returns an error. Unset parameters will\nbe ignored; unrecognized values will cause an error.\n\nUnlike the ones defined in the manifest files of the web apps, these\nsettings are provided by the browser and controlled by the users, they\nimpact the way the browser handling the web apps.\n\nSee the comment of each parameter.",
                     "parameters": [
                         {
                             "name": "manifestId",
                             "type": "string"
+                        },
+                        {
+                            "name": "linkCapturing",
+                            "description": "If user allows the links clicked on by the user in the app's scope, or\nextended scope if the manifest has scope extensions and the flags\n`DesktopPWAsLinkCapturingWithScopeExtensions` and\n`WebAppEnableScopeExtensions` are enabled.\n\nNote, the API does not support resetting the linkCapturing to the\ninitial value, uninstalling and installing the web app again will reset\nit.\n\nTODO(crbug.com/339453269): Setting this value on ChromeOS is not\nsupported yet.",
+                            "optional": true,
+                            "type": "boolean"
+                        },
+                        {
+                            "name": "displayMode",
+                            "optional": true,
+                            "$ref": "DisplayMode"
                         }
                     ]
                 }

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "devtools-protocol",
-  "version": "0.0.1317765",
+  "version": "0.0.1319565",
   "description": "The Chrome DevTools Protocol JSON",
   "repository": "https://github.com/ChromeDevTools/devtools-protocol",
   "author": "The Chromium Authors",

diff --git a/pdl/browser_protocol.pdl b/pdl/browser_protocol.pdl
@@ -12426,7 +12426,7 @@ experimental domain PWA
       # manifestId.
       optional string installUrlOrBundleUrl
 
-  # Uninstals the given manifest_id and closes any opened app windows.
+  # Uninstalls the given manifest_id and closes any opened app windows.
   command uninstall
     parameters
       string manifestId
@@ -12448,7 +12448,7 @@ experimental domain PWA
   # used to attach to via Target.attachToTarget or similar APIs.
   # If some files in the parameters cannot be handled by the web app, they will
   # be ignored. If none of the files can be handled, this API returns an error.
-  # If no files provided as the parameter, this API also returns an error.
+  # If no files are provided as the parameter, this API also returns an error.
   #
   # According to the definition of the file handlers in the manifest file, one
   # Target.TargetID may represent a page handling one or more files. The order
@@ -12465,7 +12465,39 @@ experimental domain PWA
 
   # Opens the current page in its web app identified by the manifest id, needs
   # to be called on a page target. This function returns immediately without
-  # waiting for the app finishing loading.
+  # waiting for the app to finish loading.
   command openCurrentPageInApp
     parameters
       string manifestId
+
+  # If user prefers opening the app in browser or an app window.
+  type DisplayMode extends string
+    enum
+      standalone
+      browser
+
+  # Changes user settings of the web app identified by its manifestId. If the
+  # app was not installed, this command returns an error. Unset parameters will
+  # be ignored; unrecognized values will cause an error.
+  #
+  # Unlike the ones defined in the manifest files of the web apps, these
+  # settings are provided by the browser and controlled by the users, they
+  # impact the way the browser handling the web apps.
+  #
+  # See the comment of each parameter.
+  command changeAppUserSettings
+    parameters
+      string manifestId
+      # If user allows the links clicked on by the user in the app's scope, or
+      # extended scope if the manifest has scope extensions and the flags
+      # `DesktopPWAsLinkCapturingWithScopeExtensions` and
+      # `WebAppEnableScopeExtensions` are enabled.
+      #
+      # Note, the API does not support resetting the linkCapturing to the
+      # initial value, uninstalling and installing the web app again will reset
+      # it.
+      #
+      # TODO(crbug.com/339453269): Setting this value on ChromeOS is not
+      # supported yet.
+      optional boolean linkCapturing
+      optional DisplayMode displayMode
diff --git a/types/protocol-mapping.d.ts b/types/protocol-mapping.d.ts
@@ -4988,7 +4988,7 @@ export namespace ProtocolMapping {
             returnType: void;
         };
         /**
-         * Uninstals the given manifest_id and closes any opened app windows.
+         * Uninstalls the given manifest_id and closes any opened app windows.
          */
         'PWA.uninstall': {
             paramsType: [Protocol.PWA.UninstallRequest];
@@ -5010,7 +5010,7 @@ export namespace ProtocolMapping {
          * used to attach to via Target.attachToTarget or similar APIs.
          * If some files in the parameters cannot be handled by the web app, they will
          * be ignored. If none of the files can be handled, this API returns an error.
-         * If no files provided as the parameter, this API also returns an error.
+         * If no files are provided as the parameter, this API also returns an error.
          * 
          * According to the definition of the file handlers in the manifest file, one
          * Target.TargetID may represent a page handling one or more files. The order
@@ -5025,12 +5025,27 @@ export namespace ProtocolMapping {
         /**
          * Opens the current page in its web app identified by the manifest id, needs
          * to be called on a page target. This function returns immediately without
-         * waiting for the app finishing loading.
+         * waiting for the app to finish loading.
          */
         'PWA.openCurrentPageInApp': {
             paramsType: [Protocol.PWA.OpenCurrentPageInAppRequest];
             returnType: void;
         };
+        /**
+         * Changes user settings of the web app identified by its manifestId. If the
+         * app was not installed, this command returns an error. Unset parameters will
+         * be ignored; unrecognized values will cause an error.
+         * 
+         * Unlike the ones defined in the manifest files of the web apps, these
+         * settings are provided by the browser and controlled by the users, they
+         * impact the way the browser handling the web apps.
+         * 
+         * See the comment of each parameter.
+         */
+        'PWA.changeAppUserSettings': {
+            paramsType: [Protocol.PWA.ChangeAppUserSettingsRequest];
+            returnType: void;
+        };
     }
 }
 

diff --git a/types/protocol-proxy-api.d.ts b/types/protocol-proxy-api.d.ts
@@ -4260,7 +4260,7 @@ export namespace ProtocolProxyApi {
         install(params: Protocol.PWA.InstallRequest): Promise<void>;
 
         /**
-         * Uninstals the given manifest_id and closes any opened app windows.
+         * Uninstalls the given manifest_id and closes any opened app windows.
          */
         uninstall(params: Protocol.PWA.UninstallRequest): Promise<void>;
 
@@ -4278,7 +4278,7 @@ export namespace ProtocolProxyApi {
          * used to attach to via Target.attachToTarget or similar APIs.
          * If some files in the parameters cannot be handled by the web app, they will
          * be ignored. If none of the files can be handled, this API returns an error.
-         * If no files provided as the parameter, this API also returns an error.
+         * If no files are provided as the parameter, this API also returns an error.
          * 
          * According to the definition of the file handlers in the manifest file, one
          * Target.TargetID may represent a page handling one or more files. The order
@@ -4291,10 +4291,23 @@ export namespace ProtocolProxyApi {
         /**
          * Opens the current page in its web app identified by the manifest id, needs
          * to be called on a page target. This function returns immediately without
-         * waiting for the app finishing loading.
+         * waiting for the app to finish loading.
          */
         openCurrentPageInApp(params: Protocol.PWA.OpenCurrentPageInAppRequest): Promise<void>;
 
+        /**
+         * Changes user settings of the web app identified by its manifestId. If the
+         * app was not installed, this command returns an error. Unset parameters will
+         * be ignored; unrecognized values will cause an error.
+         * 
+         * Unlike the ones defined in the manifest files of the web apps, these
+         * settings are provided by the browser and controlled by the users, they
+         * impact the way the browser handling the web apps.
+         * 
+         * See the comment of each parameter.
+         */
+        changeAppUserSettings(params: Protocol.PWA.ChangeAppUserSettingsRequest): Promise<void>;
+
     }
 }
 

diff --git a/types/protocol-tests-proxy-api.d.ts b/types/protocol-tests-proxy-api.d.ts
@@ -4646,7 +4646,7 @@ export namespace ProtocolTestsProxyApi {
         install(params: Protocol.PWA.InstallRequest): Promise<{id: number, result: void, sessionId: string}>;
 
         /**
-         * Uninstals the given manifest_id and closes any opened app windows.
+         * Uninstalls the given manifest_id and closes any opened app windows.
          */
         uninstall(params: Protocol.PWA.UninstallRequest): Promise<{id: number, result: void, sessionId: string}>;
 
@@ -4664,7 +4664,7 @@ export namespace ProtocolTestsProxyApi {
          * used to attach to via Target.attachToTarget or similar APIs.
          * If some files in the parameters cannot be handled by the web app, they will
          * be ignored. If none of the files can be handled, this API returns an error.
-         * If no files provided as the parameter, this API also returns an error.
+         * If no files are provided as the parameter, this API also returns an error.
          * 
          * According to the definition of the file handlers in the manifest file, one
          * Target.TargetID may represent a page handling one or more files. The order
@@ -4677,10 +4677,23 @@ export namespace ProtocolTestsProxyApi {
         /**
          * Opens the current page in its web app identified by the manifest id, needs
          * to be called on a page target. This function returns immediately without
-         * waiting for the app finishing loading.
+         * waiting for the app to finish loading.
          */
         openCurrentPageInApp(params: Protocol.PWA.OpenCurrentPageInAppRequest): Promise<{id: number, result: void, sessionId: string}>;
 
+        /**
+         * Changes user settings of the web app identified by its manifestId. If the
+         * app was not installed, this command returns an error. Unset parameters will
+         * be ignored; unrecognized values will cause an error.
+         * 
+         * Unlike the ones defined in the manifest files of the web apps, these
+         * settings are provided by the browser and controlled by the users, they
+         * impact the way the browser handling the web apps.
+         * 
+         * See the comment of each parameter.
+         */
+        changeAppUserSettings(params: Protocol.PWA.ChangeAppUserSettingsRequest): Promise<{id: number, result: void, sessionId: string}>;
+
     }
 }