Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to PQMass #17

Merged
merged 7 commits into from
Nov 4, 2024
Merged

Update to PQMass #17

merged 7 commits into from
Nov 4, 2024

Conversation

SammyS15
Copy link
Collaborator

I have done the following

  1. Updated the README to include more detail about PQMass as well as examples (in distribution and out of distribution) as well as advanced options
  2. Made PQMass GPU compatible that have the same results as the cpu (default) option
  3. Renamed "whiten" to "z_score_norm" as whiten doesn't tell the user what they are working with
  4. Updated notebooks to include device parameter to showcase that it could be 'cuda' if the user has access to GPU

To Do Later

  1. More encompassing test cases

I have done the following
1) Updated the README to include more detail about PQMass as well as
examples (in distribution and out of distribution) as well as advanced
options
2) Made PQMass GPU compatible that have the same results as the cpu
(default) option
3) Renamed "whiten" to "z_score_norm" as whiten doesn't tell the user
what they are working with
4) Updated notebooks to include device parameter to showcase that it
could be 'cuda' if the user has access to GPU

To Do Later
1) More encompassing test cases
Copy link
Member

@ConnorStoneAstro ConnorStoneAstro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of good stuff in here! But I think we need to keep the numpy option, when running on CPU the version with the KDTree is much faster, which is the main use case.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/pqm/pqm.py Outdated Show resolved Hide resolved
src/pqm/pqm.py Outdated Show resolved Hide resolved
src/pqm/pqm.py Outdated Show resolved Hide resolved
src/pqm/pqm.py Outdated Show resolved Hide resolved
src/pqm/pqm.py Outdated Show resolved Hide resolved
src/pqm/test_gaussian.py Outdated Show resolved Hide resolved
Copy link
Member

@ConnorStoneAstro ConnorStoneAstro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments, easy to fix

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
src/pqm/pqm.py Show resolved Hide resolved
src/pqm/pqm.py Outdated Show resolved Hide resolved
src/pqm/pqm.py Show resolved Hide resolved
src/pqm/pqm.py Show resolved Hide resolved
src/pqm/pqm.py Outdated Show resolved Hide resolved
src/pqm/pqm.py Show resolved Hide resolved
src/pqm/pqm.py Show resolved Hide resolved
src/pqm/pqm.py Outdated Show resolved Hide resolved
@SammyS15 SammyS15 merged commit 3f4d352 into main Nov 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants