-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to PQMass #17
Update to PQMass #17
Conversation
I have done the following 1) Updated the README to include more detail about PQMass as well as examples (in distribution and out of distribution) as well as advanced options 2) Made PQMass GPU compatible that have the same results as the cpu (default) option 3) Renamed "whiten" to "z_score_norm" as whiten doesn't tell the user what they are working with 4) Updated notebooks to include device parameter to showcase that it could be 'cuda' if the user has access to GPU To Do Later 1) More encompassing test cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of good stuff in here! But I think we need to keep the numpy option, when running on CPU the version with the KDTree is much faster, which is the main use case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments, easy to fix
I have done the following
To Do Later