Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now whitens the input before performing PQM test #3

Merged
merged 4 commits into from
May 31, 2024

Conversation

ConnorStoneAstro
Copy link
Member

Inputs are normalized to mean=0 and variance=1 based on the y_samples which are the reference datapoints. This is done before the reference points are taken, not sure if this matters?

@ConnorStoneAstro ConnorStoneAstro added the enhancement New feature or request label May 30, 2024
@ConnorStoneAstro ConnorStoneAstro requested a review from SammyS15 May 30, 2024 22:20
@SammyS15
Copy link
Collaborator

I don't think it matters if it is normalized. I have tested PQMass on when images were 0 to 255, and it works fine. The important element is that both x_samples and y_samples must have the same range.

@ConnorStoneAstro
Copy link
Member Author

I don't think it matters if it is normalized. I have tested PQMass on when images were 0 to 255, and it works fine. The important element is that both x_samples and y_samples must have the same range.

You are right, the normalization doesn't matter for data like that. The reason to normalize would be if there is one dimension with a range of 0 - 1000000 and the other dimensions with a range of 0 - 1. Then the first dimension will dominate all the distance calculations and the other dimensions could be very biased but that would never get detected. I talked with @LaurencePeanuts today though and we realized that in a lot of cases, the above scenario is actually fine, and you wouldn't even want to detect a bias in the tiny dimensions. So I set the whitening to False by default, but a user can turn it on if they want it.

@ConnorStoneAstro ConnorStoneAstro linked an issue May 31, 2024 that may be closed by this pull request
Copy link
Collaborator

@SammyS15 SammyS15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good after out earlier discussion

@ConnorStoneAstro ConnorStoneAstro merged commit d567bc7 into main May 31, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Whiten inputs?
2 participants