Skip to content

Commit

Permalink
fix: remove unneeded distances in geometric multiplane time delay
Browse files Browse the repository at this point in the history
  • Loading branch information
ConnorStoneAstro committed Dec 16, 2023
1 parent 687e651 commit 3acecba
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/caustics/lenses/multiplane.py
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,6 @@ def time_delay_geometric(
# Collect lens redshifts and ensure proper order
z_ls = self.get_z_ls(params)
lens_planes = [i for i, _ in sorted(enumerate(z_ls), key=itemgetter(1))]

Check warning on line 347 in src/caustics/lenses/multiplane.py

View check run for this annotation

Codecov / codecov/patch

src/caustics/lenses/multiplane.py#L346-L347

Added lines #L346 - L347 were not covered by tests
D_s = self.cosmology.transverse_comoving_distance(z_s, params)

# Compute physical position on first lens plane
D = self.cosmology.transverse_comoving_distance(z_ls[lens_planes[0]], params)
Expand All @@ -364,9 +363,6 @@ def time_delay_geometric(
D = self.cosmology.transverse_comoving_distance_z1z2(

Check warning on line 363 in src/caustics/lenses/multiplane.py

View check run for this annotation

Codecov / codecov/patch

src/caustics/lenses/multiplane.py#L362-L363

Added lines #L362 - L363 were not covered by tests
z_ls[i], z_next, params
)
D_is = self.cosmology.transverse_comoving_distance_z1z2(
z_ls[i], z_s, params
)
D_next = self.cosmology.transverse_comoving_distance(z_next, params)
alpha_x, alpha_y = self.lenses[i].physical_deflection_angle(

Check warning on line 367 in src/caustics/lenses/multiplane.py

View check run for this annotation

Codecov / codecov/patch

src/caustics/lenses/multiplane.py#L366-L367

Added lines #L366 - L367 were not covered by tests
X * rad_to_arcsec / D_l,
Expand Down

0 comments on commit 3acecba

Please sign in to comment.