tests: Time delay now tested for SIE #307
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConnorStoneAstro
added
fix
ConnorStoneAstro
requested review from
AlexandreAdam,
mjyb16 and
andreasfilipp
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #307 +/- ##
=======================================
Coverage 90.31% 90.31%
=======================================
Files 55 55
Lines 2281 2281
=======================================
Hits 2060 2060
Misses 221 221
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time delays are now tested for the SIE model for various source positions and SIE parameters. Time delays are computed from the base
ThinLensclass, so in principle this means all lenses should have correct time delays now. Still, might be good to go back and test a few other lens models. Also, should test multiplane time delay too.Note: bug found in time delay calculation and was corrected. Needed to use reduced deflection angle rather than physical.