feat: integrate got-ocr2.0 as image reader #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phv2312
changed the title
|
@phv2312, can you add a docker-compose file (allow choose the docker image for OCR service)? I think it will help people test more easily. |
taprosoft
reviewed
Oct 5, 2024
ngduyanhece
reviewed
Oct 24, 2024
ngduyanhece
reviewed
Oct 24, 2024
phv2312
force-pushed
the
feat/integrate_3rd
branch
from
25904f0
to
de703a3
Compare
|
Hi @taprosoft @cin-niko. Sorry for no update for long time. Can you help to review this PR again |
cin-niko
reviewed
Oct 28, 2024
| - We provide the docker image, with fastapi for serving the GOT-OCR2.0. Pull the image from: | ||
|
|
||
| ```bash | ||
| docker run -d --gpus all -p 8881:8881 ghcr.io/phv2312/got-ocr2.0:main |
There was a problem hiding this comment.
Should we move the docker to Kotaemon ghcr if we use GOCR as the main OCR loader?
| UnstructuredReader, | ||
| ) | ||
|
|
||
| unstructured = UnstructuredReader() |
There was a problem hiding this comment.
for consistent naming (same as in files.py): unstructured_reader
| credential=str(config("AZURE_DI_CREDENTIAL", default="")), | ||
| cache_dir=getattr(flowsettings, "KH_MARKDOWN_OUTPUT_DIR", None), | ||
| ) | ||
| adobe_reader.vlm_endpoint = azure_reader.vlm_endpoint = getattr( |
There was a problem hiding this comment.
why don't we pass vlm_endpoint in __init__ (same as in files.py)
|
|
||
| raise Exception(f"can not find the selected loader for extension: {extension}") | ||
|
|
||
| def generate_gradio_settings(self) -> dict[str, Any]: |
There was a problem hiding this comment.
IMO, the logic related to gradio UI should be implemented in ktem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Checklist