-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(loader): implement markdown parsing in MathpixPDFReader #498
Open
eliasjudin
wants to merge
2
commits into
Cinnamon:main
Choose a base branch
from
eliasjudin:mathpix-loader-updates-and-fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(loader): implement markdown parsing in MathpixPDFReader #498
eliasjudin
wants to merge
2
commits into
Cinnamon:main
from
eliasjudin:mathpix-loader-updates-and-fixes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add functionality to properly handle PDF content: - Add parse_markdown_text_to_tables method to separate tables and text - Fix load_data implementation to properly process documents - Fix lazy_load_data method - Improve document metadata handling for tables and text sections The loader now correctly processes PDFs through Mathpix API and converts content to proper Document objects.
taprosoft
changed the title
✨ feat(loader): implement markdown parsing in MathpixPDFReader
feat(loader): implement markdown parsing in MathpixPDFReader
Nov 16, 2024
@eliasjudin please check the failed CI and comments. |
taprosoft
reviewed
Nov 16, 2024
taprosoft
reviewed
Nov 16, 2024
…ation Remove early returns using super() in load_data and lazy_load_data methods that were preventing the actual implementation from being executed. This fixes the "not implemented" error while maintaining the full PDF reader functionality.
need to resolve this issue 1 validation error for CiteEvidence
evidences
Input should be a valid list [type=list_type, input_value='["Let $M$ be a multiplic...\in M$ and $x \\in X$"]', input_type=str]
For further information visit https://errors.pydantic.dev/2.9/v/list_type
Got 0 cited docs any suggestions? |
page numbering is incorrect, all items say from page 1 |
fixed this by adding check if str in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functionality to properly handle PDF content:
The loader now correctly processes PDFs through Mathpix API and converts content to proper Document objects.
Description
Type of change
Checklist