Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UI tab name and reranking process for TeiFastReranking #530

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

tknrych
Copy link

@tknrych tknrych commented Nov 27, 2024

Description

  • Please include a summary of the changes and the related issue.
  • Fixes # (issue)

Type of change

  • New features (non-breaking change).
  • Bug fix (non-breaking change).
  • Breaking change (fix or feature that would cause existing functionality not to work as expected).

Checklist

  • I have performed a self-review of my code.
  • I have added thorough tests if it is a core feature.
  • There is a reference to the original bug report and related work.
  • I have commented on my code, particularly in hard-to-understand areas.
  • The feature is well documented.

@tknrych
Copy link
Author

tknrych commented Nov 27, 2024

When using TeiFastReranking as the reranking method, if a string exceeding the Max Tokens supported by the Reranker Model specified on the TeiFastReranking Server side is passed, the server returns an error. As a result, an error warning would also be displayed on the kotaemon interface. Although the is_truncated option was present in the kotaemon code, no processing was implemented for it. To address this, functionality was added to allow specifying the max_tokens option alongside the is_truncated option. If a string exceeding the specified max_tokens is passed, the string will now be truncated accordingly.

Please ignore .gitignore and Docker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant