Fix/temperature bounding limiting heatload display in 2D sweep #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alues calculation.
ZyrnDev
approved these changes
Nov 29, 2024
ZyrnDev
deleted the
fix/temperature-bounding-limiting-heatload-display-in-2D-sweep
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The placement of my NaN check and break statement was meaning that heat load values were not being calculated if temperature bounds were exceeded, which was limiting the points on the heat graph unnecessarily.
Fixed by simply moving the NaN check for temperatures and the break statement to the end of the loop, after the heat load values have been calculated for that iteration of the loop.