Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20240412 consented flow #141

Merged
merged 10 commits into from
May 2, 2024
Merged

20240412 consented flow #141

merged 10 commits into from
May 2, 2024

Conversation

benjaminbollen
Copy link
Member

@benjaminbollen benjaminbollen commented Apr 15, 2024

fixes #140

  • implemented consented flow (with opt-out back to v1 behaviour)
  • implemented for operateFlowMatrix and groupMint
  • updated existing test path transfer for consented flow
  • updated existing tests for group mint
  • write mixed tests for consented flow
  • setAdvancedUsageFlags

Copy link
Contributor

@jaensen jaensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hub.isTrusted isn't used anymore except for some tests. Consider removing it.

lgtm

@jaensen jaensen merged commit 9461fb2 into develop May 2, 2024
1 check passed
@benjaminbollen
Copy link
Member Author

Hub.isTrusted isn't used anymore except for some tests. Consider removing it.

I thought other contracts or the SDK might still want to access the uni-directional trust relationship. Despite our lack of space in the compiled bytesize, I would consider keeping it. That said, having access to read the expiry time might be more useful over the boolean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 💪Done
Development

Successfully merging this pull request may close these issues.

consented-flow, bi-directional trust
2 participants