20240416 fitting 034 together #142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low-reentrency-guard
weeks ago with a custom build script using solc v0.8.24 directly (bypassing Forge) it builds correctly. However for development and running tests... we want a framework, that's the whole point of Forge. So for now we keep the SSTORE re-entrancy guard and close to production build we can build it with solc directly and use TSTORE instead |
|
closing this because it is confusing, and now everything can be done against develop again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name()andsymbol()in ERC1155tloadandtstorein solcv0.8.24 build