Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20240417 uri, base58 encoding, padding short names #144

Merged
merged 7 commits into from
May 2, 2024

Conversation

benjaminbollen
Copy link
Member

@benjaminbollen benjaminbollen commented Apr 30, 2024

fixes #143

  • simplify the CIDv0 storage for IPFS metadata to a cleaner storage of sha256 digest of metadata; leaving the IPFS hosting to architecture layer
  • basic coverage of unit tests of implemented base58 encoding (used for short and long names in NameRegistry)
  • always have short names be padded to 12 characters (it is unlikely an address would result in a shorter short name), so that there is no visual confusion about length of short names

@benjaminbollen benjaminbollen changed the base branch from develop to feature-v0.3.4 April 30, 2024 15:48
@benjaminbollen benjaminbollen changed the title 20240417 uri with ipfsv0 20240417 uri, base58 encoding, padding short names May 2, 2024
@benjaminbollen benjaminbollen marked this pull request as ready for review May 2, 2024 16:52
@benjaminbollen benjaminbollen merged commit 76fc410 into feature-v0.3.4 May 2, 2024
@benjaminbollen benjaminbollen linked an issue May 2, 2024 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 💪Done
Development

Successfully merging this pull request may close these issues.

fix 1155::uri, nameregistry short names
1 participant