Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

20231130 token migration #48

Merged
merged 11 commits into from
Dec 13, 2023
Merged

20231130 token migration #48

merged 11 commits into from
Dec 13, 2023

Conversation

benjaminbollen
Copy link
Member

@benjaminbollen benjaminbollen commented Dec 11, 2023 •
edited
Loading

fixes #43

  • conversion method
  • initial crude test of conversion
  • complete contract

@benjaminbollen benjaminbollen marked this pull request as ready for review December 12, 2023 17:45
benjaminbollen
benjaminbollen commented Dec 12, 2023
View reviewed changes
Copy link
Member Author

@benjaminbollen benjaminbollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-review 😻, Looks good to me

sleep overnight whether the migrate function interfaces should return uint256 amountMinted_ instead of bool success_ (or nothing at all) - even if the migration requires to mint to full expected amount

@benjaminbollen benjaminbollen self-assigned this Dec 12, 2023
@benjaminbollen
(migration): update interface for migrating tokens to return the mint…
9c47eb3 
…ed amount, which must match the intended amount
benjaminbollen
benjaminbollen commented Dec 13, 2023
View reviewed changes
Copy link
Member Author

@benjaminbollen benjaminbollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjaminbollen benjaminbollen merged commit e5693ab into master Dec 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@benjaminbollen benjaminbollen

Labels
None yet
Projects
circles-contracts-v2
Status: 💪Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(migration) token migration v1 to v2
1 participant
@benjaminbollen