-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Travis CI to Github Actions #67
Conversation
b750c26
to
107672f
Compare
107672f
to
2e1bf70
Compare
7081726
to
4975190
Compare
4975190
to
ccb6768
Compare
f421131
to
9bb82de
Compare
eb8c730
to
4276afe
Compare
Actions now reach running the core tests but we get 404 from the relayer @adzialocha found that docker-gen is having an issue with finding out the ip addresses of the created containers, so nginx-proxy doesn't know where to route the HTTP requests. There seems to be an issue with a docker update affecting that ip-addresses are not properly added as upstream in nginx configuration |
The above mentioned PRs are now merged / closed. However we still get the 404
|
Was there a new version released / do we use it already? |
Yes, super! |
I think this is ready @louilinn and @llunaCreixent ! 🥳 I've updated To test this finally we need to merge the fixed tests with this CI update, so I suggest to bring both PRs into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge! great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳 🥳 🥳 🥳 🥳
Woho! I changed the tests to --runInBand
and it works, I really think we have a race-condition bug in the relayer (started a ticket here but will add more info soon: CirclesUBI/safe-relay-service#44). For now we keep that flag and move back to concurrently running tests when the bug was fixed (created an issue here: #75).
@louilinn if you could remove that PostgreSQL part (see feedback of @llunaCreixent), I'm happy to merge it (I have the admin rights to merge it even though the Travis CI is blocking) 🌴 🐧
The PostgreSQL part is already gone :) I removed the travis file. I think we should squash all these commits when merging haha ^^ |
Related to issue: #64