Fix #130: contact us form is accepting empty feedbacks . #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tanmoysrt Sir, could you please review this PR |
|
Please do not make changes on submodule. Any changes on theme need to be done at the upstream repository |
|
@tachyons, then how can I fix this issue? To solve this problem, I need to make changes in |
|
You can make the changes to the upstream theme |
|
@tachyons, where can I get the |
|
@tachyons |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link: #130
Description:
The contact form was used to submit even when no inputs were entered. After making some changes, it now requires input before allowing submission
Snapshot
Before:
https://www.loom.com/share/4eb68bd9937a4443858c6f5ab41bdde9?sid=9c67844f-caf7-48fa-9bd4-dc4c3d5c159f
After:
https://www.loom.com/share/1265b4c8f19549a09b6d7777b9398ea3?sid=7c158744-d62d-4f69-9bff-9625421bd929