Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add blog phase 1 report Aman Asrani #221

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Asrani-Aman
Copy link
Member

Enhancing CircuitVerse User Experience | GSOC2024 | Phase 1 Report

Copy link
Member

@vedant-jain03 vedant-jain03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Asrani-Aman Looks good, added some comments, PTAL


Single sign-on (SSO) is an identification method that enables users to log in to multiple applications and websites with one set of credentials. SSO streamlines the authentication process for users.SAML (Security Assertion Markup Language) is a markup language designed for exchanging authentication information between the user, the identity provider, and the service provider.

I initially encountered a number of problems some of which are because of gem `devise-saml-authenticable` and gem `ruby-saml` versioning compatibility. Finally, I was able to redirect to the OKTA login page and obtain the SAML answer after addressing these. But then I ran into a problem while trying to sign the user which took too much time and then finally, during a meeting with Tanmoy Bhaiya, we discovered that the create method in the `saml_sessions_controller` was being overridden by the `create` method from the `devise_saml_authenticable` gem. Then finally SAML based SSO works smoothly.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Asrani-Aman Let's use "we" rather than "I", this applies to all content.
This blog is from our as a project team side to the community.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am really sorry, I shouldn't use "I"


### Email Verification at the time of User Registration

Currently, CircuitVerse doesn’t verify users’ emails during registration, so we need to implement email verification at that time. Initially, I used Sendrik as the email service, but then I get to know that CircuitVerse already has access to AWS. So, I switched to using AWS SES (Simple Email Service) to send confirmation emails.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Currently, CircuitVerse doesn’t verify users’ emails during registration, so we need to implement email verification at that time. Initially, I used Sendrik as the email service, but then I get to know that CircuitVerse already has access to AWS. So, I switched to using AWS SES (Simple Email Service) to send confirmation emails.
Currently, CircuitVerse doesn’t verify user's emails during registration, so we need to implement email verification at that time. Initially, I used Sendrik as the email service, but then I get to know that CircuitVerse already has access to AWS. So, I switched to using AWS SES (Simple Email Service) to send confirmation emails.

And above comment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be heavy file, please compress this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compress this file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compress this file

Copy link
Member

@Arnabdaz Arnabdaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not use spaces in file names as we don't know which platforms and browsers the viewers gonna use.
you can use Snake case or Camel case for naming the files

@Asrani-Aman
Copy link
Member Author

Hello @vedant-jain03,

Yes, I understand that video files are large, but these files are already compressed. Do I need to compress them further?

@Asrani-Aman
Copy link
Member Author

@vedant-jain03 @Arnabdaz done changes

1 similar comment
@Asrani-Aman
Copy link
Member Author

@vedant-jain03 @Arnabdaz done changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants