-
Notifications
You must be signed in to change notification settings - Fork 29
Ida7.7 #35
base: dev
Are you sure you want to change the base?
Ida7.7 #35
Conversation
Bump for this PR as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contributions updating the plugin! My only question is about the removal of the safe_generator
wrapping IDAW.FuncItems
. Can provide some context to this? Does FuncItems
no longer executed on the main thread? Did you experience any issues with/without the safe_generator
wrapper?
IDAW.enum_import_names(i, func) | ||
|
||
# Cycle through all instructions within the function | ||
for instr in safe_generator(IDAW.FuncItems(address)): | ||
for instr in IDAW.FuncItems(address): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could cause an issue. IIRC this was wrapped in the safe_generator due to the main thread issue. Has this changed in IDA 7.7 and higher?
Thank you for bumping this PR. I don't see any references to |
I'm not at a computer right now so apologies in advance for any formatting issues. This code referenced the old domain in the diff so I (wrongly) assumed it was still upstream. My bad. However, the online documentation still has the old domain BUT that page does seem to be updated in this repo. So maybe the docs just need to be regenerated? https://first-plugin-ida.readthedocs.io/en/latest/configuring.html#initial-installation |
related #34