Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Ida7.7 #35

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Ida7.7 #35

wants to merge 5 commits into from

Conversation

f10w3r-s
Copy link

@f10w3r-s f10w3r-s commented Jun 8, 2022

related #34

@trodery
Copy link

trodery commented May 3, 2023

Bump for this PR as first-plugin.us appears to be an unsavory site now and this PR updates this.

Copy link
Contributor

@demonduck demonduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contributions updating the plugin! My only question is about the removal of the safe_generator wrapping IDAW.FuncItems. Can provide some context to this? Does FuncItems no longer executed on the main thread? Did you experience any issues with/without the safe_generator wrapper?

IDAW.enum_import_names(i, func)

# Cycle through all instructions within the function
for instr in safe_generator(IDAW.FuncItems(address)):
for instr in IDAW.FuncItems(address):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could cause an issue. IIRC this was wrapped in the safe_generator due to the main thread issue. Has this changed in IDA 7.7 and higher?

@demonduck
Copy link
Contributor

Bump for this PR as first-plugin.us appears to be an unsavory site now and this PR updates this.

Thank you for bumping this PR. I don't see any references to first-plugin[.]us in the current plugin code or the changes made in this PR. The server defaults to first[.]talosintelligence[.]com currently

@trodery
Copy link

trodery commented May 3, 2023

Bump for this PR as first-plugin.us appears to be an unsavory site now and this PR updates this.

Thank you for bumping this PR. I don't see any references to first-plugin[.]us in the current plugin code or the changes made in this PR. The server defaults to first[.]talosintelligence[.]com currently

I'm not at a computer right now so apologies in advance for any formatting issues.

This code referenced the old domain in the diff so I (wrongly) assumed it was still upstream. My bad.

567d7ab

However, the online documentation still has the old domain BUT that page does seem to be updated in this repo. So maybe the docs just need to be regenerated?

https://first-plugin-ida.readthedocs.io/en/latest/configuring.html#initial-installation

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants