Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of optional attributes to the module 'aci_l3out_extepg' that were previously missing #471

Merged
merged 6 commits into from
Sep 13, 2023
Merged

Addition of optional attributes to the module 'aci_l3out_extepg' that were previously missing #471

merged 6 commits into from
Sep 13, 2023

Conversation

shrsr
Copy link
Collaborator

@shrsr shrsr commented Aug 30, 2023

No description provided.

@shrsr shrsr self-assigned this Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -61.10% ⚠️

Comparison is base (658ea51) 96.53% compared to head (8c1c125) 35.44%.
Report is 3 commits behind head on master.

❗ Current head 8c1c125 differs from pull request most recent head d9cb5a0. Consider uploading reports for the commit d9cb5a0 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           master     #471       +/-   ##
===========================================
- Coverage   96.53%   35.44%   -61.10%     
===========================================
  Files         181      181               
  Lines        8291     8326       +35     
  Branches     1222     1233       +11     
===========================================
- Hits         8004     2951     -5053     
- Misses        217     5375     +5158     
+ Partials       70        0       -70
Flag Coverage Δ
integration ?
sanity 35.44% <0.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
plugins/modules/aci_dhcp_relay.py 40.54% <0.00%> (-59.46%) ⬇️
plugins/modules/aci_dhcp_relay_provider.py 26.31% <0.00%> (-71.56%) ⬇️
plugins/modules/aci_l3out_extepg.py 29.41% <0.00%> (-70.59%) ⬇️

... and 173 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shrsr shrsr linked an issue Aug 30, 2023 that may be closed by this pull request
Add missing attributes for aci_l3out_extepg module #455
Closed
akinross
akinross reviewed Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few questions. Current code looks good if comments are chosen not to be done.

plugins/modules/aci_l3out_extepg.py Outdated Show resolved Hide resolved
plugins/modules/aci_l3out_extepg.py Outdated Show resolved Hide resolved
plugins/modules/aci_l3out_extepg.py Outdated Show resolved Hide resolved
@shrsr
[ignore] Added option to delete route control profile when '' is pass…
e807215 
…ed to the parameter in the module 'l3out_extepg'
gmicol
gmicol previously approved these changes Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shrsr shrsr requested a review from akinross September 1, 2023 21:15
akinross
akinross requested changes Sep 5, 2023
View reviewed changes
plugins/modules/aci_l3out_extepg.py Outdated Show resolved Hide resolved
plugins/modules/aci_l3out_extepg.py Outdated Show resolved Hide resolved
plugins/modules/aci_l3out_extepg.py Show resolved Hide resolved
@shrsr shrsr requested review from akinross and gmicol September 5, 2023 14:34
@shrsr
[ignore] Modified function to collect key and values directly from th…
711fc32 
…e route control profiles dictionary in 'l3out_extepg' module
akinross
akinross previously approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anvitha-jain
anvitha-jain previously approved these changes Sep 5, 2023
View reviewed changes
lhercot
lhercot requested changes Sep 5, 2023
View reviewed changes
plugins/modules/aci_l3out_extepg.py Outdated Show resolved Hide resolved
plugins/modules/aci_l3out_extepg.py Outdated Show resolved Hide resolved
plugins/modules/aci_l3out_extepg.py Outdated Show resolved Hide resolved
@shrsr shrsr dismissed stale reviews from anvitha-jain and akinross via 2752004 September 7, 2023 16:44
@shrsr shrsr requested a review from lhercot September 7, 2023 16:58
gmicol
gmicol approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akinross
akinross approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lhercot
lhercot approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit d3264a6 into CiscoDevNet:master Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmicol gmicol gmicol approved these changes

@anvitha-jain anvitha-jain anvitha-jain approved these changes

@akinross akinross akinross approved these changes

@lhercot lhercot lhercot approved these changes

@sajagana sajagana Awaiting requested review from sajagana sajagana is a code owner

Assignees

@shrsr shrsr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing attributes for aci_l3out_extepg module
5 participants
@shrsr @lhercot @akinross @anvitha-jain @gmicol