Add 'preference' attribute to aci_l3out_static_routes_nexthop (DCNE-303) #722
Conversation
yamauchih1213
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
sajagana,
samiib and
shrsr
as code owners
github-actions
bot
changed the title
| preference: | ||
| description: | ||
| - The administrative preference value for the nexthop | ||
| type: int |
There was a problem hiding this comment.
Could you document the default value apic sets when not provided and the allowed integer range, think it is 1-255 if not mistaken. Could you validate this and adjust the docs suggestion below.
| preference: | |
| description: | |
| - The administrative preference value for the nexthop | |
| type: int | |
| preference: | |
| description: | |
| - The administrative preference value for the nexthop. | |
| - The APIC defaults to 0 when unset during creation. | |
| - The value must be between 1 and 255. | |
| type: int |
There was a problem hiding this comment.
Thank you for your feedback!
After further investigation, I found that the UI tooltip confirms that 0 is also a permitted value, along with "defaultValue" and "unspecified". Additionally, in actual testing, specifying 0 worked without issues, while 256 resulted in an error.
Based on this, I will update the documentation to reflect that 0 is a valid option, in addition to 1-255. Please let me know if you have any concerns about this approach.
There was a problem hiding this comment.
Thanks for checking. Sure 0-255 is fine, if you can adjust that it is good.
There was a problem hiding this comment.
Fixed. Please confirm. Thank you!
| - name: Verify default preference | ||
| ansible.builtin.assert: | ||
| that: | ||
| - add_nh_no_pref.is_changed |
There was a problem hiding this comment.
is there a reason to use is_changed? could you keep consistent with the rest?
| - add_nh_no_pref.is_changed | |
| - add_nh_no_pref is changed |
There was a problem hiding this comment.
Thank you for your confirmation. It's my mistake. I will correct it as you pointed out. excuse me.
There was a problem hiding this comment.
Fixed. Please confirm. Thank you!
Summary
This PR adds a new attribute,
preference, to theaci_l3out_static_routes_nexthopmodule, enabling the configuration of a preference value for next-hop IP addresses in static routes. This change addresses a common use case where routing preferences need to be explicitly set for better control over routing decisions.Changes
preferenceattribute toaci_l3out_static_routes_nexthopNotes
preferenceattribute is optional. If omitted, the API will use the default value of0.preferencevalue.