updates rust_g; adds rustg-based icon_states; fixes unit tests #5644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
size/M
timothyteakettle
previously approved these changes
Jun 22, 2023
silicons
force-pushed
the
memory_optimizations_4
branch
from
d5c46bc
to
51aec90
Compare
github-actions
bot
added
size/L
added 2 commits
June 22, 2023 19:08
silicons
changed the title
silicons
changed the title
added 2 commits
June 22, 2023 20:01
ktoma36
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so back when i did inventory slot refactor i added this thing called a render state cacheit basically allows for lazy people to default when needed and don't default when not needed
problem isto facilitate this we need to icon_states
which seems to be using just an exorbitant amount of memory.
byond icon_states bad
replaced with rustg icon states
there's a massive footgun in that it's obviously going to be slow due to the fcopy() but for the use case of inventory it should be fine.
frees about 400MB.
also fixes us just having bad shuttle paths