Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makes markings transfer over when ahealed/regenerating + aheals dont remove NIFs #5646

Conversation

timothyteakettle
Copy link
Contributor

@timothyteakettle timothyteakettle commented Jun 23, 2023

About The Pull Request

title

regarding NIFs:
xenochimera removing NIFs is intended, nobody ever coded (emergent gameplay!), now it actually removes it instead of sending it to the shadow realm
aheals removing markings and NIFs was never intended so um yes

Why It's Good For The Game

why would you lose them

Changelog

🆑
fix: makes markings transfer over when ahealed/regenerating
/:cl:

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 23, 2023
@timothyteakettle
Copy link
Contributor Author

tested this and it works

@timothyteakettle timothyteakettle changed the title makes markings transfer over when ahealed/regenerating makes markings transfer over when ahealed/regenerating + aheals dont remove NIFs Jun 23, 2023
@timothyteakettle
Copy link
Contributor Author

tested the NIF stuff and it also works

@ktoma36 ktoma36 merged commit b91703b into Citadel-Station-13:master Jun 25, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants