Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRIUMPH SECURITY EQUIPMENT STORAGE, ARMORY, AND FIGHTER BAY REWORK #5713

Conversation

Nut2
Copy link
Contributor

@Nut2 Nut2 commented Jul 16, 2023

About The Pull Request

Puts plate carriers, tags, plates, and helmets, as well as helmet covers into the sec equipment storage
revamps the armory with the same gear as the atlas
replaces the shitty shuttles within the security fighter bay with the barons from the atlas

Why It's Good For The Game

it sucked before :(

@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 16, 2023
@TheLordME TheLordME added the good first pr Good contribution from a newcomer label Jul 16, 2023
@TheLordME
Copy link
Collaborator

A couple things:

  1. grafik
  2. dont add items to preset lockers (the security officer lockers in this case) via mapping. add them in the definition instead. You can find the definition of contents in file code\game\objects\structures\crates_lockers\closets\secure\security.dm the list you want to edit starts at line 322, add a comma at the last entry and add the warrant projector or what ever you are adding to the lockers after that, make sure you are still in the parenthesis. I could live with you just removing the items from the lockers in this PR, and making a seperate PR to add them to the definition.
  3. decals on floors and walls where they dont make sense
    grafik
  4. Firealarm was removed (not an actual issue, but maybe add a new one somewhere
    grafik

@silicons silicons merged commit cf65584 into Citadel-Station-13:master Jul 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first pr Good contribution from a newcomer size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants