Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codebase reorganization of some folders #5717

Merged
merged 3 commits into from
Jul 20, 2023

Conversation

silicons
Copy link
Contributor

moves & renames _onclick and _rendering to click and rendering and moves _onclick/hud to rendering/legacy_hud
moves those to game folder

Why?

because i don't think the root /code folder having them is correct
what the idea is is that:

  • /code/game has 'whole game' stuff that should depend on as little else as possible (can't avoid stuff like subsystems atmos and tgui obviously so this is a loose suggestion); this is more aimed at that we shouldn't have, say, a hypospray in here when hyposprays are logically part of the reagents module since hyposprays don't work without reagents and are primarily content for engaging with the reagents module
  • /code/modules are standalone 'modules' that contain a tightly related subset of the game, e.g. chemistry, maploader/management systems, etc.
  • /code/controllers are core systems; many of them rely on / utilize stuff from game/modules (duh) but they're here forever since they're important
  • /code/datums are mostly just helper datums; object/item/whatever-specific datums should be stored in their given files.

@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. Merge Conflict labels Jul 16, 2023
@timothyteakettle timothyteakettle merged commit bbd6e42 into Citadel-Station-13:master Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants