A variety of circuit fucky wuckys fixes. #6623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
size/L
silicons
pushed a commit
that referenced
this pull request
Jul 26, 2024
silicons
pushed a commit
that referenced
this pull request
Jul 27, 2024
silicons
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This fixes a few problems that still remained (or got implemented by bugged behavior being fixed) with circuits.
Particularly, it makes sure pins display their output text properly; a bug I accidentally introduced earlier.
Circuit components loading will also load their data before being put in a assembly proper. (that way, names display correctly.)
It also makes sure that where applicable, circuits will actually use the helpers for data screwyness.
As a side effect, the above (with a few tweaks) also fixes an issue where raw references were getting stored in lists.
Finally, list cooldowns were reduced to the standard (otherwise this makes them very awkward to work with.)
Theoretically I could atomize this PR further, but, uh, a lot of it was just bug fixes.
Why It's Good For The Game
fixes a variety of bugs.
For the list cooldown tweaks, some of them would have 0.1 CD, some would have 1, and there was no real correlation to which had what. I don't really think the cooldown feature should limit circuits realistically (which this would do.) if they are wholly internal.
Changelog
🆑
tweak: Circuit list component cooldowns are now universally 0.1.
fix: Circuit lists won't sneak full references in when transferred.
fix: Circuit components will now properly use helpers for IO input/output.
fix: Circuit names will load properly if from a custom import.
fix: Circuit input/outputs will display their text once again.
/:cl: