Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inhand interaction refactor #6633

Merged
merged 10 commits into from
Aug 1, 2024

Conversation

silicons
Copy link
Contributor

Adds and standardizes hooks for

Activate inhand (wield)
Unique action (pump shotgun, etc)
Defensive toggle (shield modes)
Defensive trigger (shield special)

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 29, 2024
@silicons silicons marked this pull request as ready for review July 29, 2024 15:31
Copy link
Member

@deathride58 deathride58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny nitpick; looks good for testmerge

Comment on lines 22 to 23
// SHOULD_NOT_OVERRIDE(TRUE)
// SHOULD_NOT_SLEEP(TRUE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are these commented

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments are not for storing old code

silicons pushed a commit that referenced this pull request Jul 31, 2024
silicons pushed a commit that referenced this pull request Jul 31, 2024
silicons pushed a commit that referenced this pull request Jul 31, 2024
silicons pushed a commit that referenced this pull request Jul 31, 2024
Copy link
Collaborator

@TheLordME TheLordME left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are not for storing old code

Comment on lines 22 to 23
// SHOULD_NOT_OVERRIDE(TRUE)
// SHOULD_NOT_SLEEP(TRUE)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments are not for storing old code

silicons pushed a commit that referenced this pull request Jul 31, 2024
@TheLordME TheLordME merged commit 64ec254 into Citadel-Station-13:master Aug 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. Test Merge Candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants