Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kills off Baymiss and RNG misses making you look like a doofus at random similar to how ANY other bay derivative has done. #6667

Closed

Conversation

IrkallaEpsilon
Copy link
Contributor

@IrkallaEpsilon IrkallaEpsilon commented Aug 17, 2024

A percent chance to miss shots and throws even if you click on the guy or lead your shots are just not good gameplay.

I have missed at near point blank ranges already.

About The Pull Request

Removes baymiss. This should have been done a long time ago to be honest. Shit "mechanic". I think removal was attempted in one of the gun refactors but theres still residue in human_defense etc. that still makes me miss with an AEG at point blank range while two handing.

I think I hit every single instance of baymiss. Evasion stat for mobs should (TM) still work. Removal is very similar to baycode baymiss removal. I think Chomp did a similar thing a year ago.

	var/distance = get_dist(TT.initial_turf, loc)
	miss_chance = max(5 * (distance - 2), 0) 

Let me get this straight: Its 20% at 6 tiles distance. 15% at 5. So basically even if you as the player have god aim and god clicks you still are bound to miss relatively often no matter the gun you use, no matter the character. Amazing.

Why It's Good For The Game

Actually having people being good at clicking matter. Actually having an actual ammo count instead of having 50 rounds P90 mag out of which 7.5 rounds are bound to miss.

Changelog

🆑
del: Baymiss wont be missed.
/:cl:

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 17, 2024
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 17, 2024
@IrkallaEpsilon IrkallaEpsilon changed the title Begins killing off Baymiss and RNG misses making you look like a doofus at random. Kills off Baymiss and RNG misses making you look like a doofus at random similar to how ANY other bay derivative has done. Aug 17, 2024
@silicons
Copy link
Contributor

#6579

@silicons
Copy link
Contributor

testmerge it tho

@IrkallaEpsilon
Copy link
Contributor Author

Gaming

silicons pushed a commit that referenced this pull request Aug 23, 2024
silicons pushed a commit that referenced this pull request Aug 23, 2024
silicons pushed a commit that referenced this pull request Aug 25, 2024
silicons pushed a commit that referenced this pull request Aug 25, 2024
Copy link

github-actions bot commented Sep 1, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ two week, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked by The Massive Refactor of The Week size/S Denotes a PR that changes 10-29 lines, ignoring generated files. Stale Test Merge Candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants