refactors attack hand proc header #6720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silicons
commented
Sep 1, 2024
Comment on lines
+31
to
38
| // todo: better desc | ||
| // todo: e_args is not specified all the time, yet. | ||
| /atom/proc/attack_hand(mob/user, datum/event_args/actor/clickchain/e_args) | ||
| // todo: remove | ||
| if(isnull(e_args)) | ||
| e_args = new(user) | ||
| // end | ||
| if(on_attack_hand(e_args)) |
There was a problem hiding this comment.
you may have noticed e_args isn't provided in most places
this is because everyone is uh, wrong. like. you're supposed to call attack_hand from clickchain, but people just lazy-out and have it called from literally fucking everywhere
list/params doesn't work for that reason.
so we're continuing the pattern; we'll slowly bring things around.
TheLordME
previously approved these changes
Sep 2, 2024
github-actions
bot
added
the
size/M
silicons
pushed a commit
that referenced
this pull request
Sep 4, 2024
silicons
pushed a commit
that referenced
this pull request
Sep 4, 2024
BlueWildrose
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed for #5677
this is to make that PR slightly easier to review.