Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xenobotany requirement traits stop water / nutriment depletion. #6736

Merged

Conversation

Niezann
Copy link
Contributor

@Niezann Niezann commented Sep 6, 2024

About The Pull Request

for some reason trait_requires_nutrients / requires_water just stops the health. instead of like. just stopping nutrient/water intake. (which I would like it to do)
so farm bot would just go schizo
I also dont think it actually works as it should as it was before.
you also had no way of telling what the actual drain of both was, because the trait removes the visibility of intakes from the scanner.

This PR just basically makes the trait more obvious in what it does by making plants not drain their respective resource if they have that gene trait.

Why It's Good For The Game

the trait was super obscured and actually just sort of made it impossible to restore your plants, making the trait sort of a negative one. now it's a lot more obvious as to what it's doing, and it correlates better to its actual name so the Farmbot doesn't also just go Schizo.

Changelog

🆑
tweak: Xenobotany's trait_requires_water & trait_requires_nutrient now stop the depletion of water/nutrient instead of health loss from a lack of either.
/:cl:

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 6, 2024
silicons pushed a commit that referenced this pull request Sep 8, 2024
silicons pushed a commit that referenced this pull request Sep 8, 2024
silicons pushed a commit that referenced this pull request Sep 9, 2024
silicons pushed a commit that referenced this pull request Sep 9, 2024
@BlueWildrose BlueWildrose merged commit 4d488f8 into Citadel-Station-13:master Sep 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants