-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix dependency install bug #19
Conversation
This reverts commit 653322e.
Pipfile
Outdated
black = "*" | ||
|
||
[requires] | ||
python_version = "3.9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimmonsRitchie you can configure your IDE to automatically add a new line at the end of file on save, so Github won't show the red error icon above. See more here https://thoughtbot.com/blog/no-newline-at-end-of-file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch and great tip! Thanks, @LienDang. This should be fixed now 😊
Looks good to me! |
Excellent! Thanks, @LienDang! Merging now 🚀 |
Summary
Updates our Pipfile to fix a dependency conflict issue that has caused our scheduled Github action to fail for the past two months. It also:
Why are we doing this?
We want working scrapers! These changes are modeled heavily on the Pipfiles of our others repos, particularly city-scrapers, which are functioning properly.
These changes appear to have achieved their goal: both our CI and cronjob workflows are now working.
How can these changes be manually tested?
pipenv --rm
pipenv sync --dev
pytest && black . --check
scrapy validate
For extra credit, you can check that the cronjob workflow works as expected by manually triggering it from this page and using the dropdown menu (pictured below). Just note that it will take about an hour to run:
Are there any smells or added technical debt to note?