⛔ Remove pypiwin32 package #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing two packages from the project's Pipfile as they are already included as subdependencies by other top-level dependencies. I don't think we need to include them as top-level dependencies.
SimmonsRitchie
changed the title
|
@City-Bureau/pdw, I think since we were on the same page about this change in the city-scraper repo and it's pretty low-risk, I'm just going to cowboy merge this. I'm probably going to need to implement this fix for all 16 city-scraper repos, so it probably doesn't make sense for ya'll to review each change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Deletes pypiwin32 from our Pipfile and rebuilds our lock file, which appears to solve a dependency bug that was causing our
CIGithub workflow to fail. This same fix was implemented for our city-scrapers repo.This PR also:
Why are we doing this?
In a recent PR I immediately experienced an identical dependency installation failure as described here in our city-scrapers repo. See that PR for further notes and discussion.
Requiring python 3.9 and the removal of chardet & twisted weren't necessary in order to resolve this issue but I felt it made sense to clean up the Pipfile while I was removing pypiwin32.
Are there any smells or added technical debt to note?
See the PR in city-scrapers for further notes and discussion.