👾 Integrate scrapy-sentry-errors #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimmonsRitchie
force-pushed
the
new-sentry
branch
from
f535964
to
7b5ae3b
Compare
SimmonsRitchie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Replaces the scrapy-sentry package with scrapy-sentry-errors. It also:
Why are we doing this?
scrapy-sentryneeded to be replaced in this repo because it hasn't been maintained and appears to be causing strange dependency conflicts in a number of our city-scraper repos.scrapy-sentry-errorsis our new, custom-built package for error monitoring. It functions virtually identically but uses newer python packaging practices and features key dependency upgrades.Steps to manually test
n/a
Are there any smells or added technical debt to note?
n/a