🛠️ Fix: Restore spiders SSA 51 and 54 #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimmonsRitchie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
This PR restores
chi_ssa_51andchia_ssa_54Why are we doing this?
The spiders above appear to have been accidentally deleted in #1091. Those spiders were deleted using a script which appears to have had overly broad file detection, sweeping up these other spiders because they had they shared a similar file name stem "chi_ssa_5".
Steps to manually test
n/a
Are there any smells or added technical debt to note?
After discovering this case, I'm a little concerned other spiders may also have been accidentally deleted three months ago when I went on a deprecation spree. I'm pretty hopeful the damage should be minimal though. It's pretty rare that our spiders share such similar names.