Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API for latest application's applicant #440

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

rbreve
Copy link
Contributor

@rbreve rbreve commented Oct 21, 2024

In order to make accesible the latest applicant's address information added the API endpoint.
Save applicantion's address to application instead of using the profile address, this change was needed when the user would delete his address from his profile making it unaccesible from the application.

@rbreve rbreve force-pushed the address_api_application branch 3 times, most recently from 46e7b55 to 8425468 Compare October 21, 2024 17:50
Copy link
Contributor

@voneiden voneiden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall implementation seems OK, needs a little fine tuning 😃

application_form/tests/test_sales_application_api.py Outdated Show resolved Hide resolved
application_form/api/views.py Outdated Show resolved Hide resolved
application_form/api/views.py Outdated Show resolved Hide resolved
application_form/api/views.py Outdated Show resolved Hide resolved
application_form/api/serializers.py Outdated Show resolved Hide resolved
application_form/api/views.py Outdated Show resolved Hide resolved
application_form/api/views.py Outdated Show resolved Hide resolved
application_form/api/views.py Outdated Show resolved Hide resolved
@rbreve rbreve force-pushed the address_api_application branch 8 times, most recently from e778790 to 19e1323 Compare October 28, 2024 12:30
@voneiden voneiden self-requested a review October 28, 2024 12:36
application_form/api/views.py Outdated Show resolved Hide resolved
asko_import/serializers.py Outdated Show resolved Hide resolved
@rbreve rbreve force-pushed the address_api_application branch 5 times, most recently from 1a3db92 to 9f041d5 Compare October 28, 2024 13:57
In order to make accesible the latest applicant's address information
added the API endpoint.
Save applicantion's address to application instead of using the profile
address, this change was needed when the user would delete
his address from his profile making it unaccesible from
the application.
@rbreve rbreve force-pushed the address_api_application branch from 9f041d5 to de83db1 Compare October 28, 2024 13:59
Copy link

Copy link
Contributor

@voneiden voneiden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rbreve rbreve merged commit d2ac255 into main Oct 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants