RATYK-18: Make parent determination conditions less strict #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danipran
force-pushed
the
RATYK-18/fix-import
branch
from
dd8b2a0
to
2f3fb02
Compare
tuomas777
reviewed
Apr 17, 2024
Use relative values rather than absolute values.
danipran
force-pushed
the
RATYK-18/fix-import
branch
from
2f3fb02
to
ec4714b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the import fails if an area doesn't have a parent ID and doesn't overlap almost precisely 100% with any other area (<0.000001 whatever units this is using), i.e. the error margin is very, very strict. The source data can be a bit inaccurate with the areas. Using relative values rather than absolute values for determining whether an area has enough overlap with a parent area makes the importer work again while still being reasonably accurate (the areas must overlap at least by 99.99%).
No unit tests, unfortunately. This library has a single unit test, so adding tests for this would be a pretty big task.