Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP-1166 adjust language field styles and frontpage view theme borders #609

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

IiroJarv
Copy link
Contributor

@IiroJarv IiroJarv commented Feb 20, 2024

Actions necessary for applying the changes: (for example composer install; drush updb; drush cim)

Drush deploy

Fixes language field theming in taxonomy view cards,
Service language (both service language and service place language,
Most recent favourites view language field,
Front page view header theming touchups

Testing instructions:

  • Login and check front page most recent favourites view confirm that the view uses the new language field and doesnt have the speech bubble icon
  • Check the views on the front page and confirm they don't have double borders in the table header
  • Go to some taxonomy view (for exsample /palvelut-helsinkiläisille) and confirm languages with set language levels have spaces after commas
  • Go to some service and confirm that both service language and service place and time language fields have space after commas

Review checklist:

  • The code conforms to Drupal coding standards
  • I have reviewed the code for security and quality issues
  • I have tested the code with the proper user roles
  • I have moved the ticket to the approval lane, added testing instructions and assigned it to the product owner.

@IiroJarv IiroJarv merged commit 8280bbf into develop Feb 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants