Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/tp 1269 details select element display bug #616

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

IiroJarv
Copy link
Contributor

@IiroJarv IiroJarv commented Feb 28, 2024

Actions necessary for applying the changes: (for example composer install; drush updb; drush cim)

Drush cr

Changes to select--langcode and select--moderation-state caused unwanted effects.
Reverted the changes and applied wanted theming effect for group views in another way.

Testing instructions:

  • Login edit service
  • Check that details sidebar is themed properly
  • Check that select elements on the form
  • Go to search page and check select element theming
  • Go to group page and go through the view and confirm that langcode and moderation filters are themed properly

Review checklist:

  • The code conforms to Drupal coding standards
  • I have reviewed the code for security and quality issues
  • I have tested the code with the proper user roles
  • I have moved the ticket to the approval lane, added testing instructions and assigned it to the product owner.

@IiroJarv IiroJarv merged commit ffe4423 into develop Feb 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants