HDS-711: New component for Highlight and Quote #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # Highlight | ||
|
|
||
| <StatusLabel type="alert" variant="rounded">Beta</StatusLabel> |
There was a problem hiding this comment.
This is missing the Accessible StatusLabel and tooltip. Copy the implementation from another component's docs.
There was a problem hiding this comment.
The tooltip is missing too. If you look at for example site/src/docs/components/accordion/tabs.mdx, there's the StatuslabelTooltip component after these, and all of them are wrapped inside a <div class="status-label-description">.
harriplappalainen
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds component for Highlights and Quotes and needed documentation. More detailed description in the tickets below
Motivation and Context
HDS-711
HDS-712
HDS-1643
How Has This Been Tested?
Tested locally
Demos
React stories
Core stories
Documentation