Release-4.0.0: (HDS-2390) remove ariaLabel and dataTestId #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 1 files 18 suites 3m 27s ⏱️ Results for commit 015be6e. ♻️ This comment has been updated with latest results. |
|
Preview found from hds-demo docs/preview_1359 Demos |
Removed aria-label descripiton when not necessary or useful.
NikoHelle
force-pushed
the
hds-2390-rm-attributes
branch
from
78f5112
to
015be6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AriaLabel and dataTestId are marked depreacated in 3.10.0 and now removed in favor of native aria-label and data-testid
Removed also unnecessary documentation of these props unless the prop is required.
Related Issue
Closes HDS-2390
How Has This Been Tested?
Snapshots updated.
Demos:
Links to demos are in the comments
Screenshots (if appropriate):
Add to changelog