Hds 2393 core scss v4 for breadcrumbs #1369
Conversation
…pe to add CommonHTMLAttributes as data-* to props.
The arrow icon takes now space. Therefore it needed a background color and container and aligner elements.
…date The old command has rimraf which removes all images.
Include showArrow and information -props to the component props
…from Table Heading id is created when needed Table id was for checkbox and it is also created when needed. Updated docs, tests and snapshot.
Better usage of core css. Cannot use compose in core, so not-so-inconvenient "helper-text-gap" was added.
…exists Short HelperText stays on same line as ErrorText
Flexbox change requires label + tooltip combination to be wrapped. Made external components or otherwise focus would be lost from tooltip button on re-render, if anonymous functions were used.
Release-4.0.0: (HDS-2421) Storybook files typescript checking
…ts, add body spacing to helper for body-overflowing pages
Release-4.0.0 HDS-2425 hero changes
…ight-test-separate-running Release-4.0.0 HDS-2423 enable playwright test separate running and write instructions
…-native-attributes release-4.0.0 HDS-2388 icon template native attributes
…ft-right-to-start-end Release-4.0.0 (HDS-2420) Dialog, Header and StatusLabel icon-props renamed
Release-4.0.0 HDS-2272 fix koros examples, remova old and add new visual tests
|
Preview found from hds-demo docs/preview_1369 Demos |
Test Results 1 files 22 suites 3m 45s ⏱️ Results for commit 3000a39. ♻️ This comment has been updated with latest results. |
| } | ||
| } | ||
|
|
||
| @media (min-width: 768px) { |
There was a problem hiding this comment.
I wonder if some variable is available (breakpoint?) for these?
There was a problem hiding this comment.
Also make sure that the old loki-screenshots are deleted and add to loki config to skip breadcrumb testing (this should always be done when creating new e2e test for components until all loki tests are replaced)
Removed aria-label descripiton when not necessary or useful.
Release-4.0.0: (HDS-2390) remove ariaLabel and dataTestId
timwessman
force-pushed
the
hds-2393-core-scss-v4-for-breadcrumbs
branch
from
cc5d630
to
b5a87f2
Compare
timwessman
force-pushed
the
hds-2393-core-scss-v4-for-breadcrumbs
branch
from
b5a87f2
to
35277ce
Compare
|
Hups, this is broken now (it renders only the last item of the Breadcrumb), I'll fix it. |
|
Found out that you can't use css variables on media query declarations, so I reverted breakpoints back to numerical values. There have to be some trick, maybe from scss, but I think it's not on scope of this pr. |
NikoHelle
force-pushed
the
release-4.0.0
branch
from
e33d8e6
to
d48fe2d
Compare
Description
Something to think
react/src/components/breadcrumb/Breadcrumb.module.scssI keepedcomposes: from-notation to split elements from css selectors. It is actually quite clean to do it this way, but its not the same logic that I used in the Button -component. So which one is better? or something else?Related Issue
Closes HDS-2393
How Has This Been Tested?
Add to changelog